From: Krzysztof Wilczyński <kw@linux.com>
Date: Fri, 8 Oct 2021 22:27:32 +0000 (+0000)
Subject: PCI: Use unsigned to match sscanf("%x") in pci_dev_str_match_path()
X-Git-Tag: microblaze-v5.18~520^2~15^2~7
X-Git-Url: http://git.monstr.eu/?a=commitdiff_plain;h=357df2fc00661e0993e0e40d1a56bdd967f45c17;p=linux-2.6-microblaze.git

PCI: Use unsigned to match sscanf("%x") in pci_dev_str_match_path()

Cppcheck warns that pci_dev_str_match_path() passes pointers to signed ints
to sscanf("%x"), which expects pointers to *unsigned* ints:

  invalidScanfArgType_int drivers/pci/pci.c:312 %x in format string (no. 2) requires 'unsigned int *' but the argument type is 'signed int *'.

Declare the variables as unsigned to avoid this issue.

[bhelgaas: commit log]
Link: https://lore.kernel.org/r/20211008222732.2868493-3-kw@linux.com
Signed-off-by: Krzysztof Wilczyński <kw@linux.com>
Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>
---

diff --git a/drivers/pci/pci.c b/drivers/pci/pci.c
index ce2ab62b64cf..7998b65e9ae5 100644
--- a/drivers/pci/pci.c
+++ b/drivers/pci/pci.c
@@ -269,7 +269,7 @@ static int pci_dev_str_match_path(struct pci_dev *dev, const char *path,
 				  const char **endptr)
 {
 	int ret;
-	int seg, bus, slot, func;
+	unsigned int seg, bus, slot, func;
 	char *wpath, *p;
 	char end;