From: Nava kishore Manne Date: Wed, 12 Jun 2019 11:14:39 +0000 (+0200) Subject: serial: uartps: Use octal permission for module_param() X-Git-Tag: microblaze-v5.4-rc1~332^2~25 X-Git-Url: http://git.monstr.eu/?a=commitdiff_plain;h=26d5a3245b3f3ce406277e7584f7ccbbd5ea98bb;p=linux-2.6-microblaze.git serial: uartps: Use octal permission for module_param() Octal permission is preffered compare to symbolic one. This patch fixes checkpatch warnings: Symbolic permissions 'S_IRUGO' are not preferred. Consider using octal permissions '0444'. Fixes: 85baf542d54e ("tty: xuartps: support 64 byte FIFO size") Signed-off-by: Nava kishore Manne Signed-off-by: Michal Simek Signed-off-by: Greg Kroah-Hartman --- diff --git a/drivers/tty/serial/xilinx_uartps.c b/drivers/tty/serial/xilinx_uartps.c index 73ae0cacc961..32cf67598bc3 100644 --- a/drivers/tty/serial/xilinx_uartps.c +++ b/drivers/tty/serial/xilinx_uartps.c @@ -37,12 +37,12 @@ /* Rx Trigger level */ static int rx_trigger_level = 56; static int uartps_major; -module_param(rx_trigger_level, uint, S_IRUGO); +module_param(rx_trigger_level, uint, 0444); MODULE_PARM_DESC(rx_trigger_level, "Rx trigger level, 1-63 bytes"); /* Rx Timeout */ static int rx_timeout = 10; -module_param(rx_timeout, uint, S_IRUGO); +module_param(rx_timeout, uint, 0444); MODULE_PARM_DESC(rx_timeout, "Rx timeout, 1-255"); /* Register offsets for the UART. */