From: Josh Poimboeuf Date: Tue, 14 Feb 2023 07:05:39 +0000 (-0800) Subject: csky/cpu: Make sure arch_cpu_idle_dead() doesn't return X-Git-Tag: microblaze-v6.6~593^2~47 X-Git-Url: http://git.monstr.eu/?a=commitdiff_plain;h=1b2442a835a0acc7d76ae2f48ca7a94f962b29c8;p=linux-2.6-microblaze.git csky/cpu: Make sure arch_cpu_idle_dead() doesn't return arch_cpu_idle_dead() doesn't return. Make that more explicit with a BUG(). BUG() is preferable to unreachable() because BUG() is a more explicit failure mode and avoids undefined behavior like falling off the edge of the function into whatever code happens to be next. Acked-by: Guo Ren Link: https://lore.kernel.org/r/1e9ecc3d248e82973e80bc336fc9f97e3ba2708d.1676358308.git.jpoimboe@kernel.org Signed-off-by: Josh Poimboeuf --- diff --git a/arch/csky/kernel/smp.c b/arch/csky/kernel/smp.c index b45d1073307f..0ec20efaf5fd 100644 --- a/arch/csky/kernel/smp.c +++ b/arch/csky/kernel/smp.c @@ -317,5 +317,7 @@ void arch_cpu_idle_dead(void) "jmpi csky_start_secondary" : : "r" (secondary_stack)); + + BUG(); } #endif