From: Krzysztof Kozlowski Date: Wed, 7 Apr 2021 15:45:35 +0000 (+0200) Subject: memory: samsung: exynos5422-dmc: handle clk_set_parent() failure X-Git-Tag: microblaze-v5.14~170^2~1^2~1 X-Git-Url: http://git.monstr.eu/?a=commitdiff_plain;h=132c17c3ff878c7beaba51bdd275d5cc654c0e33;p=linux-2.6-microblaze.git memory: samsung: exynos5422-dmc: handle clk_set_parent() failure clk_set_parent() can fail and ignoring such case could lead to invalid clock setup for given frequency. Addresses-Coverity: Unchecked return value Fixes: 6e7674c3c6df ("memory: Add DMC driver for Exynos5422") Signed-off-by: Krzysztof Kozlowski Reviewed-by: Lukasz Luba Link: https://lore.kernel.org/r/20210407154535.70756-1-krzysztof.kozlowski@canonical.com --- diff --git a/drivers/memory/samsung/exynos5422-dmc.c b/drivers/memory/samsung/exynos5422-dmc.c index 1dabb509dec3..dee503640e12 100644 --- a/drivers/memory/samsung/exynos5422-dmc.c +++ b/drivers/memory/samsung/exynos5422-dmc.c @@ -1298,7 +1298,9 @@ static int exynos5_dmc_init_clks(struct exynos5_dmc *dmc) dmc->curr_volt = target_volt; - clk_set_parent(dmc->mout_mx_mspll_ccore, dmc->mout_spll); + ret = clk_set_parent(dmc->mout_mx_mspll_ccore, dmc->mout_spll); + if (ret) + return ret; clk_prepare_enable(dmc->fout_bpll); clk_prepare_enable(dmc->mout_bpll);