From: Denis Arefev Date: Fri, 15 Mar 2024 09:37:58 +0000 (+0300) Subject: mtd: partitions: redboot: Added conversion of operands to a larger type X-Git-Tag: microblaze-v6.13~1142^2~7 X-Git-Url: http://git.monstr.eu/?a=commitdiff_plain;h=1162bc2f8f5de7da23d18aa4b7fbd4e93c369c50;p=linux-2.6-microblaze.git mtd: partitions: redboot: Added conversion of operands to a larger type The value of an arithmetic expression directory * master->erasesize is subject to overflow due to a failure to cast operands to a larger data type before perfroming arithmetic Found by Linux Verification Center (linuxtesting.org) with SVACE. Signed-off-by: Denis Arefev Signed-off-by: Miquel Raynal Link: https://lore.kernel.org/linux-mtd/20240315093758.20790-1-arefev@swemel.ru --- diff --git a/drivers/mtd/parsers/redboot.c b/drivers/mtd/parsers/redboot.c index a16b42a88581..3b55b676ca6b 100644 --- a/drivers/mtd/parsers/redboot.c +++ b/drivers/mtd/parsers/redboot.c @@ -102,7 +102,7 @@ nogood: offset -= master->erasesize; } } else { - offset = directory * master->erasesize; + offset = (unsigned long) directory * master->erasesize; while (mtd_block_isbad(master, offset)) { offset += master->erasesize; if (offset == master->size)