From: Arnd Bergmann Date: Thu, 2 Nov 2017 11:34:24 +0000 (+0100) Subject: serial: mvebu-uart: drop incorrect memset X-Git-Tag: microblaze-4.16-rc1~387^2~25 X-Git-Url: http://git.monstr.eu/?a=commitdiff_plain;h=0ea46e6e58ab7447222bcaa10be0adcd9f92284d;p=linux-2.6-microblaze.git serial: mvebu-uart: drop incorrect memset gcc points out that the length passed into memset here is wrong: drivers/tty/serial/mvebu-uart.c: In function 'mvebu_uart_probe': arch/x86/include/asm/string_32.h:324:29: error: 'memset' used with length equal to number of elements without multiplication by element size [-Werror=memset-elt-size] Moreover, the structure was allocated with kzalloc a few lines earlier, so that memset is also unnecessary. Let's drop it to shut up the compiler warning. Fixes: 95f787685a22 ("serial: mvebu-uart: dissociate RX and TX interrupts") Signed-off-by: Arnd Bergmann Signed-off-by: Greg Kroah-Hartman --- diff --git a/drivers/tty/serial/mvebu-uart.c b/drivers/tty/serial/mvebu-uart.c index 16b0a5aa14e2..85eb5c86d177 100644 --- a/drivers/tty/serial/mvebu-uart.c +++ b/drivers/tty/serial/mvebu-uart.c @@ -817,7 +817,6 @@ static int mvebu_uart_probe(struct platform_device *pdev) } /* Manage interrupts */ - memset(mvuart->irq, 0, UART_IRQ_COUNT); if (platform_irq_count(pdev) == 1) { /* Old bindings: no name on the single unamed UART0 IRQ */ irq = platform_get_irq(pdev, 0);