From: Friedrich Vock Date: Tue, 14 May 2024 07:06:38 +0000 (+0200) Subject: drm/amdgpu: Check if NBIO funcs are NULL in amdgpu_device_baco_exit X-Git-Tag: microblaze-v6.13~537^2~32^2~204 X-Git-Url: http://git.monstr.eu/?a=commitdiff_plain;h=0cdb3f9740844b9d95ca413e3fcff11f81223ecf;p=linux-2.6-microblaze.git drm/amdgpu: Check if NBIO funcs are NULL in amdgpu_device_baco_exit The special case for VM passthrough doesn't check adev->nbio.funcs before dereferencing it. If GPUs that don't have an NBIO block are passed through, this leads to a NULL pointer dereference on startup. Signed-off-by: Friedrich Vock Fixes: 1bece222eabe ("drm/amdgpu: Clear doorbell interrupt status for Sienna Cichlid") Cc: Alex Deucher Cc: Christian König Acked-by: Christian König Signed-off-by: Alex Deucher --- diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c index 00fe3c2d5431..e72e774d17e6 100644 --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c @@ -6167,7 +6167,7 @@ int amdgpu_device_baco_exit(struct drm_device *dev) adev->nbio.funcs->enable_doorbell_interrupt) adev->nbio.funcs->enable_doorbell_interrupt(adev, true); - if (amdgpu_passthrough(adev) && + if (amdgpu_passthrough(adev) && adev->nbio.funcs && adev->nbio.funcs->clear_doorbell_interrupt) adev->nbio.funcs->clear_doorbell_interrupt(adev);