From: Hugo Villeneuve Date: Mon, 7 Oct 2024 16:27:15 +0000 (-0400) Subject: serial: sc16is7xx: announce support for SER_RS485_RTS_ON_SEND X-Git-Tag: microblaze-v6.16~489^2~28 X-Git-Url: http://git.monstr.eu/?a=commitdiff_plain;h=068d35a7be65fa3bca4bba21c269bfe0b39158a6;p=linux-2.6-microblaze.git serial: sc16is7xx: announce support for SER_RS485_RTS_ON_SEND When specifying flag SER_RS485_RTS_ON_SEND in RS485 configuration, we get the following warning after commit 4afeced55baa ("serial: core: fix sanitizing check for RTS settings"): invalid RTS setting, using RTS_AFTER_SEND instead This results in SER_RS485_RTS_AFTER_SEND being set and the driver always write to the register field SC16IS7XX_EFCR_RTS_INVERT_BIT, which breaks some hardware using these chips. The hardware supports both RTS_ON_SEND and RTS_AFTER_SEND modes, so fix this by announcing support for RTS_ON_SEND. Signed-off-by: Hugo Villeneuve Suggested-by: Konstantin Pugin Link: https://lore.kernel.org/lkml/20240422133219.2710061-2-ria.freelander@gmail.com Reviewed-by: Andy Shevchenko Tested-by: Hugo Villeneuve Link: https://lore.kernel.org/r/20241007162716.3122912-1-hugo@hugovil.com Signed-off-by: Greg Kroah-Hartman --- diff --git a/drivers/tty/serial/sc16is7xx.c b/drivers/tty/serial/sc16is7xx.c index ad88a33a504f..9d0c971e49f5 100644 --- a/drivers/tty/serial/sc16is7xx.c +++ b/drivers/tty/serial/sc16is7xx.c @@ -1473,7 +1473,7 @@ static int sc16is7xx_setup_mctrl_ports(struct sc16is7xx_port *s, } static const struct serial_rs485 sc16is7xx_rs485_supported = { - .flags = SER_RS485_ENABLED | SER_RS485_RTS_AFTER_SEND, + .flags = SER_RS485_ENABLED | SER_RS485_RTS_ON_SEND | SER_RS485_RTS_AFTER_SEND, .delay_rts_before_send = 1, .delay_rts_after_send = 1, /* Not supported but keep returning -EINVAL */ };