From: Markus Elfring Date: Thu, 16 Nov 2017 10:22:26 +0000 (+0100) Subject: ALSA: korg1212: Delete a duplicate function call "release_firmware" in snd_korg1212_c... X-Git-Tag: microblaze-4.16-rc6~231^2~25^2 X-Git-Url: http://git.monstr.eu/?a=commitdiff_plain;ds=sidebyside;h=cf576fe5fd74cdabf7fc3fd8ac3b9abea9b964f8;p=linux-2.6-microblaze.git ALSA: korg1212: Delete a duplicate function call "release_firmware" in snd_korg1212_create() The function "release_firmware" is called in the current implementation of the function "_request_firmware" after a failure was detected. Link: https://elixir.free-electrons.com/linux/v4.14-rc8/source/drivers/base/firmware_class.c#L1196 Such a call should therefore not be repeated directly after the corresponding error information was received in the local variable "err" of the function "snd_korg1212_create". Thus remove a misplaced function call. Signed-off-by: Markus Elfring Signed-off-by: Takashi Iwai --- diff --git a/sound/pci/korg1212/korg1212.c b/sound/pci/korg1212/korg1212.c index c7b007164c99..4206ba44d8bb 100644 --- a/sound/pci/korg1212/korg1212.c +++ b/sound/pci/korg1212/korg1212.c @@ -2348,7 +2348,6 @@ static int snd_korg1212_create(struct snd_card *card, struct pci_dev *pci, err = request_firmware(&dsp_code, "korg/k1212.dsp", &pci->dev); if (err < 0) { - release_firmware(dsp_code); snd_printk(KERN_ERR "firmware not available\n"); snd_korg1212_free(korg1212); return err;