selftests: mlxsw: Reduce runtime of tc-police scale test
authorIdo Schimmel <idosch@mellanox.com>
Sun, 23 Aug 2020 08:06:27 +0000 (11:06 +0300)
committerDavid S. Miller <davem@davemloft.net>
Tue, 25 Aug 2020 00:36:11 +0000 (17:36 -0700)
Currently, the test takes about 626 seconds to complete because of an
inefficient use of the device's TCAM. Reduce the runtime to 202 seconds
by inserting all the flower filters with the same preference and mask,
but with a different key.

In particular, this reduces the deletion of the qdisc (which triggers
the deletion of all the filters) from 66 seconds to 0.2 seconds. This
prevents various netlink requests from user space applications (e.g.,
systemd-networkd) from timing-out because RTNL is not held for too long
anymore.

Signed-off-by: Ido Schimmel <idosch@mellanox.com>
Reviewed-by: Jiri Pirko <jiri@mellanox.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
tools/testing/selftests/drivers/net/mlxsw/tc_police_scale.sh

index 4b96561..3e3e06e 100644 (file)
@@ -24,6 +24,13 @@ tc_police_switch_destroy()
        simple_if_fini $swp1
 }
 
+tc_police_addr()
+{
+       local num=$1; shift
+
+       printf "2001:db8:1::%x" $num
+}
+
 tc_police_rules_create()
 {
        local count=$1; shift
@@ -34,8 +41,9 @@ tc_police_rules_create()
        for ((i = 0; i < count; ++i)); do
                cat >> $TC_POLICE_BATCH_FILE <<-EOF
                        filter add dev $swp1 ingress \
-                               prot ip \
-                               flower skip_sw \
+                               prot ipv6 \
+                               pref 1000 \
+                               flower skip_sw dst_ip $(tc_police_addr $i) \
                                action police rate 10mbit burst 100k \
                                conform-exceed drop/ok
                EOF