USB: serial: mos7720: fix error code in mos7720_write()
authorDan Carpenter <dan.carpenter@oracle.com>
Thu, 28 Jan 2021 09:35:23 +0000 (12:35 +0300)
committerJohan Hovold <johan@kernel.org>
Thu, 28 Jan 2021 09:57:22 +0000 (10:57 +0100)
This code should return -ENOMEM if the kmalloc() fails but instead
it returns success.

Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Fixes: 0f64478cbc7a ("USB: add USB serial mos7720 driver")
Cc: stable@vger.kernel.org
Signed-off-by: Johan Hovold <johan@kernel.org>
drivers/usb/serial/mos7720.c

index ed347a6..aa55169 100644 (file)
@@ -1094,8 +1094,10 @@ static int mos7720_write(struct tty_struct *tty, struct usb_serial_port *port,
        if (urb->transfer_buffer == NULL) {
                urb->transfer_buffer = kmalloc(URB_TRANSFER_BUFFER_SIZE,
                                               GFP_ATOMIC);
-               if (!urb->transfer_buffer)
+               if (!urb->transfer_buffer) {
+                       bytes_sent = -ENOMEM;
                        goto exit;
+               }
        }
        transfer_size = min(count, URB_TRANSFER_BUFFER_SIZE);