libata: support concurrent positioning ranges log

Add support to discover if an ATA device supports the Concurrent
Positioning Ranges data log (address 0x47), indicating that the device
is capable of seeking to multiple different locations in parallel using
multiple actuators serving different LBA ranges.

Also add support to translate the concurrent positioning ranges log
into its equivalent Concurrent Positioning Ranges VPD page B9h in
libata-scsi.c.

The format of the Concurrent Positioning Ranges Log is defined in ACS-5
r9.

Signed-off-by: Damien Le Moal <damien.lemoal@wdc.com>
Reviewed-by: Hannes Reinecke <hare@suse.de>
Reviewed-by: Christoph Hellwig <hch@lst.de>
Reviewed-by: Martin K. Petersen <martin.petersen@oracle.com>
Reviewed-by: Keith Busch <kbusch@kernel.org>
Link: https://lore.kernel.org/r/20211027022223.183838-4-damien.lemoal@wdc.com
Signed-off-by: Jens Axboe <axboe@kernel.dk>

diff --git a/drivers/ata/libata-core.c b/drivers/ata/libata-core.c
index eed6531..75f1a6c 100644 (file)
--- a/drivers/ata/libata-core.c
+++ b/drivers/ata/libata-core.c
@@ -2459,18 +2459,70 @@ static void ata_dev_config_devslp(struct ata_device *dev)
        }
 }
 
+static void ata_dev_config_cpr(struct ata_device *dev)
+{
+       unsigned int err_mask;
+       size_t buf_len;
+       int i, nr_cpr = 0;
+       struct ata_cpr_log *cpr_log = NULL;
+       u8 *desc, *buf = NULL;
+
+       if (!ata_identify_page_supported(dev,
+                                ATA_LOG_CONCURRENT_POSITIONING_RANGES))
+               goto out;
+
+       /*
+        * Read IDENTIFY DEVICE data log, page 0x47
+        * (concurrent positioning ranges). We can have at most 255 32B range
+        * descriptors plus a 64B header.
+        */
+       buf_len = (64 + 255 * 32 + 511) & ~511;
+       buf = kzalloc(buf_len, GFP_KERNEL);
+       if (!buf)
+               goto out;
+
+       err_mask = ata_read_log_page(dev, ATA_LOG_IDENTIFY_DEVICE,
+                                    ATA_LOG_CONCURRENT_POSITIONING_RANGES,
+                                    buf, buf_len >> 9);
+       if (err_mask)
+               goto out;
+
+       nr_cpr = buf[0];
+       if (!nr_cpr)
+               goto out;
+
+       cpr_log = kzalloc(struct_size(cpr_log, cpr, nr_cpr), GFP_KERNEL);
+       if (!cpr_log)
+               goto out;
+
+       cpr_log->nr_cpr = nr_cpr;
+       desc = &buf[64];
+       for (i = 0; i < nr_cpr; i++, desc += 32) {
+               cpr_log->cpr[i].num = desc[0];
+               cpr_log->cpr[i].num_storage_elements = desc[1];
+               cpr_log->cpr[i].start_lba = get_unaligned_le64(&desc[8]);
+               cpr_log->cpr[i].num_lbas = get_unaligned_le64(&desc[16]);
+       }
+
+out:
+       swap(dev->cpr_log, cpr_log);
+       kfree(cpr_log);
+       kfree(buf);
+}
+
 static void ata_dev_print_features(struct ata_device *dev)
 {
        if (!(dev->flags & ATA_DFLAG_FEATURES_MASK))
                return;
 
        ata_dev_info(dev,
-                    "Features:%s%s%s%s%s\n",
+                    "Features:%s%s%s%s%s%s\n",
                     dev->flags & ATA_DFLAG_TRUSTED ? " Trust" : "",
                     dev->flags & ATA_DFLAG_DA ? " Dev-Attention" : "",
                     dev->flags & ATA_DFLAG_DEVSLP ? " Dev-Sleep" : "",
                     dev->flags & ATA_DFLAG_NCQ_SEND_RECV ? " NCQ-sndrcv" : "",
-                    dev->flags & ATA_DFLAG_NCQ_PRIO ? " NCQ-prio" : "");
+                    dev->flags & ATA_DFLAG_NCQ_PRIO ? " NCQ-prio" : "",
+                    dev->cpr_log ? " CPR" : "");
 }
 
 /**
@@ -2634,6 +2686,7 @@ int ata_dev_configure(struct ata_device *dev)
                ata_dev_config_sense_reporting(dev);
                ata_dev_config_zac(dev);
                ata_dev_config_trusted(dev);
+               ata_dev_config_cpr(dev);
                dev->cdb_len = 32;
 
                if (ata_msg_drv(ap) && print_info)

diff --git a/drivers/ata/libata-scsi.c b/drivers/ata/libata-scsi.c
index 1fb4611..15a279f 100644 (file)
--- a/drivers/ata/libata-scsi.c
+++ b/drivers/ata/libata-scsi.c
@@ -1895,7 +1895,7 @@ static unsigned int ata_scsiop_inq_std(struct ata_scsi_args *args, u8 *rbuf)
  */
 static unsigned int ata_scsiop_inq_00(struct ata_scsi_args *args, u8 *rbuf)
 {
-       int num_pages;
+       int i, num_pages = 0;
        static const u8 pages[] = {
                0x00,   /* page 0x00, this page */
                0x80,   /* page 0x80, unit serial no page */
@@ -1905,13 +1905,17 @@ static unsigned int ata_scsiop_inq_00(struct ata_scsi_args *args, u8 *rbuf)
                0xb1,   /* page 0xb1, block device characteristics page */
                0xb2,   /* page 0xb2, thin provisioning page */
                0xb6,   /* page 0xb6, zoned block device characteristics */
+               0xb9,   /* page 0xb9, concurrent positioning ranges */
        };
 
-       num_pages = sizeof(pages);
-       if (!(args->dev->flags & ATA_DFLAG_ZAC))
-               num_pages--;
+       for (i = 0; i < sizeof(pages); i++) {
+               if (pages[i] == 0xb6 &&
+                   !(args->dev->flags & ATA_DFLAG_ZAC))
+                       continue;
+               rbuf[num_pages + 4] = pages[i];
+               num_pages++;
+       }
        rbuf[3] = num_pages;    /* number of supported VPD pages */
-       memcpy(rbuf + 4, pages, num_pages);
        return 0;
 }
 
@@ -2121,6 +2125,26 @@ static unsigned int ata_scsiop_inq_b6(struct ata_scsi_args *args, u8 *rbuf)
        return 0;
 }
 
+static unsigned int ata_scsiop_inq_b9(struct ata_scsi_args *args, u8 *rbuf)
+{
+       struct ata_cpr_log *cpr_log = args->dev->cpr_log;
+       u8 *desc = &rbuf[64];
+       int i;
+
+       /* SCSI Concurrent Positioning Ranges VPD page: SBC-5 rev 1 or later */
+       rbuf[1] = 0xb9;
+       put_unaligned_be16(64 + (int)cpr_log->nr_cpr * 32 - 4, &rbuf[3]);
+
+       for (i = 0; i < cpr_log->nr_cpr; i++, desc += 32) {
+               desc[0] = cpr_log->cpr[i].num;
+               desc[1] = cpr_log->cpr[i].num_storage_elements;
+               put_unaligned_be64(cpr_log->cpr[i].start_lba, &desc[8]);
+               put_unaligned_be64(cpr_log->cpr[i].num_lbas, &desc[16]);
+       }
+
+       return 0;
+}
+
 /**
  *     modecpy - Prepare response for MODE SENSE
  *     @dest: output buffer
@@ -4120,11 +4144,17 @@ void ata_scsi_simulate(struct ata_device *dev, struct scsi_cmnd *cmd)
                        ata_scsi_rbuf_fill(&args, ata_scsiop_inq_b2);
                        break;
                case 0xb6:
-                       if (dev->flags & ATA_DFLAG_ZAC) {
+                       if (dev->flags & ATA_DFLAG_ZAC)
                                ata_scsi_rbuf_fill(&args, ata_scsiop_inq_b6);
-                               break;
-                       }
-                       fallthrough;
+                       else
+                               ata_scsi_set_invalid_field(dev, cmd, 2, 0xff);
+                       break;
+               case 0xb9:
+                       if (dev->cpr_log)
+                               ata_scsi_rbuf_fill(&args, ata_scsiop_inq_b9);
+                       else
+                               ata_scsi_set_invalid_field(dev, cmd, 2, 0xff);
+                       break;
                default:
                        ata_scsi_set_invalid_field(dev, cmd, 2, 0xff);
                        break;

diff --git a/include/linux/ata.h b/include/linux/ata.h
index 1b44f40..199e47e 100644 (file)
--- a/include/linux/ata.h
+++ b/include/linux/ata.h
@@ -329,6 +329,7 @@ enum {
        ATA_LOG_SECURITY          = 0x06,
        ATA_LOG_SATA_SETTINGS     = 0x08,
        ATA_LOG_ZONED_INFORMATION = 0x09,
+       ATA_LOG_CONCURRENT_POSITIONING_RANGES = 0x47,
 
        /* Identify device SATA settings log:*/
        ATA_LOG_DEVSLP_OFFSET     = 0x30,

diff --git a/include/linux/libata.h b/include/linux/libata.h
index c0c64f0..236ec68 100644 (file)
--- a/include/linux/libata.h
+++ b/include/linux/libata.h
@@ -676,6 +676,18 @@ struct ata_ering {
        struct ata_ering_entry  ring[ATA_ERING_SIZE];
 };
 
+struct ata_cpr {
+       u8                      num;
+       u8                      num_storage_elements;
+       u64                     start_lba;
+       u64                     num_lbas;
+};
+
+struct ata_cpr_log {
+       u8                      nr_cpr;
+       struct ata_cpr          cpr[];
+};
+
 struct ata_device {
        struct ata_link         *link;
        unsigned int            devno;          /* 0 or 1 */
@@ -735,6 +747,9 @@ struct ata_device {
        u32                     zac_zones_optimal_nonseq;
        u32                     zac_zones_max_open;
 
+       /* Concurrent positioning ranges */
+       struct ata_cpr_log      *cpr_log;
+
        /* error history */
        int                     spdn_cnt;
        /* ering is CLEAR_END, read comment above CLEAR_END */