drm/panfrost: Remove set but not used variable 'bo'
authorYueHaibing <yuehaibing@huawei.com>
Mon, 3 Feb 2020 15:27:24 +0000 (15:27 +0000)
committerRob Herring <robh@kernel.org>
Wed, 12 Feb 2020 19:49:55 +0000 (13:49 -0600)
Fixes gcc '-Wunused-but-set-variable' warning:

drivers/gpu/drm/panfrost/panfrost_job.c: In function 'panfrost_job_cleanup':
drivers/gpu/drm/panfrost/panfrost_job.c:278:31: warning:
 variable 'bo' set but not used [-Wunused-but-set-variable]

commit bdefca2d8dc0 ("drm/panfrost: Add the panfrost_gem_mapping concept")
involved this unused variable.

Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: YueHaibing <yuehaibing@huawei.com>
Reviewed-by: Steven Price <steven.price@arm.com>
Reviewed-by: Alyssas Rosenzweig <alyssa.rosenzweig@collabora.com>
Signed-off-by: Rob Herring <robh@kernel.org>
Link: https://patchwork.freedesktop.org/patch/msgid/20200203152724.42611-1-yuehaibing@huawei.com
drivers/gpu/drm/panfrost/panfrost_job.c

index 7157dfd..9a1a72a 100644 (file)
@@ -280,12 +280,8 @@ static void panfrost_job_cleanup(struct kref *ref)
        }
 
        if (job->bos) {
-               struct panfrost_gem_object *bo;
-
-               for (i = 0; i < job->bo_count; i++) {
-                       bo = to_panfrost_bo(job->bos[i]);
+               for (i = 0; i < job->bo_count; i++)
                        drm_gem_object_put_unlocked(job->bos[i]);
-               }
 
                kvfree(job->bos);
        }