PCI: endpoint: pci-epf-test: Remove superfluous checks for pci_epf_alloc_space() API
authorNiklas Cassel <cassel@kernel.org>
Wed, 7 Feb 2024 21:39:16 +0000 (22:39 +0100)
committerManivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
Fri, 9 Feb 2024 17:10:22 +0000 (22:40 +0530)
Now that the checks are performed by the pci_epf_alloc_space() API, let's
remove the superfluous checks in this driver.

Signed-off-by: Niklas Cassel <cassel@kernel.org>
Reviewed-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
Reviewed-by: Frank Li <Frank.Li@nxp.com>
Link: https://lore.kernel.org/r/20240207213922.1796533-4-cassel@kernel.org
[mani: reworded commit message]
Signed-off-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
drivers/pci/endpoint/functions/pci-epf-test.c

index 15bfa7d..981894e 100644 (file)
@@ -841,12 +841,6 @@ static int pci_epf_test_alloc_space(struct pci_epf *epf)
        }
        test_reg_size = test_reg_bar_size + msix_table_size + pba_size;
 
-       if (epc_features->bar_fixed_size[test_reg_bar]) {
-               if (test_reg_size > bar_size[test_reg_bar])
-                       return -ENOMEM;
-               test_reg_size = bar_size[test_reg_bar];
-       }
-
        base = pci_epf_alloc_space(epf, test_reg_size, test_reg_bar,
                                   epc_features, PRIMARY_INTERFACE);
        if (!base) {
@@ -888,8 +882,6 @@ static void pci_epf_configure_bar(struct pci_epf *epf,
                bar_fixed_64bit = !!(epc_features->bar_fixed_64bit & (1 << i));
                if (bar_fixed_64bit)
                        epf_bar->flags |= PCI_BASE_ADDRESS_MEM_TYPE_64;
-               if (epc_features->bar_fixed_size[i])
-                       bar_size[i] = epc_features->bar_fixed_size[i];
        }
 }