tty: don't check for signal_pending() in send_break()
authorJiri Slaby (SUSE) <jirislaby@kernel.org>
Tue, 19 Sep 2023 08:51:55 +0000 (10:51 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Tue, 3 Oct 2023 12:31:16 +0000 (14:31 +0200)
msleep_interruptible() will check on its own. So no need to do the check
in send_break() before calling the above.

Signed-off-by: "Jiri Slaby (SUSE)" <jirislaby@kernel.org>
Link: https://lore.kernel.org/r/20230919085156.1578-15-jirislaby@kernel.org
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/tty/tty_io.c

index 87bb509..24833b3 100644 (file)
@@ -2484,8 +2484,7 @@ static int send_break(struct tty_struct *tty, unsigned int duration)
        retval = tty->ops->break_ctl(tty, -1);
        if (retval)
                goto out;
-       if (!signal_pending(current))
-               msleep_interruptible(duration);
+       msleep_interruptible(duration);
        retval = tty->ops->break_ctl(tty, 0);
 out:
        tty_write_unlock(tty);