Input: synaptics-rmi4 - fix the error return code in rmi_probe_interrupts()
authorWei Yongjun <weiyongjun1@huawei.com>
Mon, 11 Jun 2018 17:09:15 +0000 (10:09 -0700)
committerDmitry Torokhov <dmitry.torokhov@gmail.com>
Mon, 11 Jun 2018 17:19:08 +0000 (10:19 -0700)
The error return code PTR_ERR(data->irqdomain) is always 0 since
data->irqdomain is equal to NULL in this error handling case.

Fixes: 24d28e4f1271 ("Input: synaptics-rmi4 - convert irq distribution to irq_domain")
Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
Reviewed-by: Lyude Paul <lyude@redhat.com>
Reviewed-by: Nick Desaulniers <ndesaulniers@google.com>
Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
drivers/input/rmi4/rmi_driver.c

index 2fb0ae0..cb6d983 100644 (file)
@@ -1043,7 +1043,7 @@ int rmi_probe_interrupts(struct rmi_driver_data *data)
                                                   data);
        if (!data->irqdomain) {
                dev_err(&rmi_dev->dev, "Failed to create IRQ domain\n");
-               return PTR_ERR(data->irqdomain);
+               return -ENOMEM;
        }
 
        data->irq_count = irq_count;