drm/bridge: parade-ps8640: Fix regulator supply order
authorChen-Yu Tsai <wenst@chromium.org>
Thu, 21 Jul 2022 09:22:58 +0000 (17:22 +0800)
committerRobert Foss <robert.foss@linaro.org>
Thu, 21 Jul 2022 12:50:36 +0000 (14:50 +0200)
The datasheet says that VDD12 must be enabled and at full voltage before
VDD33 is enabled.

Reorder the bulk regulator supply names so that VDD12 is enabled before
VDD33. Any enable ramp delays should be handled by setting proper
constraints on the regulators.

Fixes: bc1aee7fc8f0 ("drm/bridge: Add I2C based driver for ps8640 bridge")
Signed-off-by: Chen-Yu Tsai <wenst@chromium.org>
Reviewed-by: Neil Armstrong <narmstrong@baylibre.com>
Signed-off-by: Robert Foss <robert.foss@linaro.org>
Link: https://patchwork.freedesktop.org/patch/msgid/20220721092258.3397461-1-wenst@chromium.org
drivers/gpu/drm/bridge/parade-ps8640.c

index 31e88cb..49107a6 100644 (file)
@@ -631,8 +631,8 @@ static int ps8640_probe(struct i2c_client *client)
        if (!ps_bridge)
                return -ENOMEM;
 
-       ps_bridge->supplies[0].supply = "vdd33";
-       ps_bridge->supplies[1].supply = "vdd12";
+       ps_bridge->supplies[0].supply = "vdd12";
+       ps_bridge->supplies[1].supply = "vdd33";
        ret = devm_regulator_bulk_get(dev, ARRAY_SIZE(ps_bridge->supplies),
                                      ps_bridge->supplies);
        if (ret)