PM / devfreq: rk3399_dmc: Simplify with dev_err_probe()
authorKrzysztof Kozlowski <krzk@kernel.org>
Sun, 28 Feb 2021 06:52:32 +0000 (15:52 +0900)
committerChanwoo Choi <cw00.choi@samsung.com>
Thu, 8 Apr 2021 04:14:50 +0000 (13:14 +0900)
Common pattern of handling deferred probe can be simplified with
dev_err_probe().  Less code and the error value gets printed.

Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
Signed-off-by: Chanwoo Choi <cw00.choi@samsung.com>
drivers/devfreq/rk3399_dmc.c

index 9e9d3b4..293857e 100644 (file)
@@ -324,22 +324,14 @@ static int rk3399_dmcfreq_probe(struct platform_device *pdev)
        mutex_init(&data->lock);
 
        data->vdd_center = devm_regulator_get(dev, "center");
-       if (IS_ERR(data->vdd_center)) {
-               if (PTR_ERR(data->vdd_center) == -EPROBE_DEFER)
-                       return -EPROBE_DEFER;
-
-               dev_err(dev, "Cannot get the regulator \"center\"\n");
-               return PTR_ERR(data->vdd_center);
-       }
+       if (IS_ERR(data->vdd_center))
+               return dev_err_probe(dev, PTR_ERR(data->vdd_center),
+                                    "Cannot get the regulator \"center\"\n");
 
        data->dmc_clk = devm_clk_get(dev, "dmc_clk");
-       if (IS_ERR(data->dmc_clk)) {
-               if (PTR_ERR(data->dmc_clk) == -EPROBE_DEFER)
-                       return -EPROBE_DEFER;
-
-               dev_err(dev, "Cannot get the clk dmc_clk\n");
-               return PTR_ERR(data->dmc_clk);
-       }
+       if (IS_ERR(data->dmc_clk))
+               return dev_err_probe(dev, PTR_ERR(data->dmc_clk),
+                                    "Cannot get the clk dmc_clk\n");
 
        data->edev = devfreq_event_get_edev_by_phandle(dev, "devfreq-events", 0);
        if (IS_ERR(data->edev))