drm/amd/amdgpu/amdgpu_drv.c: Replace drm_modeset_lock_all with drm_modeset_lock
authorFabio M. De Francesco <fmdefrancesco@gmail.com>
Tue, 27 Apr 2021 09:44:49 +0000 (11:44 +0200)
committerAlex Deucher <alexander.deucher@amd.com>
Mon, 10 May 2021 22:06:45 +0000 (18:06 -0400)
drm_modeset_lock_all() is not needed here, so it is replaced with
drm_modeset_lock(). The crtc list around which we are looping never
changes, therefore the only lock we need is to protect access to
crtc->state.

Suggested-by: Daniel Vetter <daniel@ffwll.ch>
Suggested-by: Matthew Wilcox <willy@infradead.org>
Signed-off-by: Fabio M. De Francesco <fmdefrancesco@gmail.com>
Reviewed-by: Matthew Wilcox (Oracle) <willy@infradead.org>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c

index 3ec732d..cbabac1 100644 (file)
@@ -1599,17 +1599,15 @@ static int amdgpu_pmops_runtime_idle(struct device *dev)
        if (amdgpu_device_has_dc_support(adev)) {
                struct drm_crtc *crtc;
 
-               drm_modeset_lock_all(drm_dev);
-
                drm_for_each_crtc(crtc, drm_dev) {
-                       if (crtc->state->active) {
+                       drm_modeset_lock(&crtc->mutex, NULL);
+                       if (crtc->state->active)
                                ret = -EBUSY;
+                       drm_modeset_unlock(&crtc->mutex);
+                       if (ret < 0)
                                break;
-                       }
                }
 
-               drm_modeset_unlock_all(drm_dev);
-
        } else {
                struct drm_connector *list_connector;
                struct drm_connector_list_iter iter;