media: imx-jpeg: Fix error return code in mxc_jpeg_probe()
authorWei Yongjun <weiyongjun1@huawei.com>
Tue, 23 Mar 2021 11:28:55 +0000 (12:28 +0100)
committerMauro Carvalho Chehab <mchehab+huawei@kernel.org>
Tue, 6 Apr 2021 08:30:25 +0000 (10:30 +0200)
Fix to return negative error code from the error handling
case instead of 0, as done elsewhere in this function.

Fixes: 2db16c6ed72c ("media: imx-jpeg: Add V4L2 driver for i.MX8 JPEG Encoder/Decoder")
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
drivers/media/platform/imx-jpeg/mxc-jpeg.c

index adb1715..54c93ae 100644 (file)
@@ -2022,12 +2022,14 @@ static int mxc_jpeg_probe(struct platform_device *pdev)
        jpeg->m2m_dev = v4l2_m2m_init(&mxc_jpeg_m2m_ops);
        if (IS_ERR(jpeg->m2m_dev)) {
                dev_err(dev, "failed to register v4l2 device\n");
+               ret = PTR_ERR(jpeg->m2m_dev);
                goto err_m2m;
        }
 
        jpeg->dec_vdev = video_device_alloc();
        if (!jpeg->dec_vdev) {
                dev_err(dev, "failed to register v4l2 device\n");
+               ret = -ENOMEM;
                goto err_vdev_alloc;
        }
        if (mode == MXC_JPEG_ENCODE)