drm/sun4i: tv: Add missing reset assertion
authorMaxime Ripard <maxime@cerno.tech>
Mon, 29 Aug 2022 13:11:54 +0000 (15:11 +0200)
committerMaxime Ripard <maxime@cerno.tech>
Wed, 7 Sep 2022 08:30:47 +0000 (10:30 +0200)
The reset line is deasserted at bind, and asserted if we ever encounter an
error there. However, it's never asserted in unbind which will lead to a
resource unbalance.

Reviewed-by: Jernej Skrabec <jernej.skrabec@gmail.com>
Signed-off-by: Maxime Ripard <maxime@cerno.tech>
Link: https://patchwork.freedesktop.org/patch/msgid/20220728-rpi-analog-tv-properties-v2-40-459522d653a7@cerno.tech
drivers/gpu/drm/sun4i/sun4i_tv.c

index d3bf8fb..5965a0f 100644 (file)
@@ -610,6 +610,7 @@ static void sun4i_tv_unbind(struct device *dev, struct device *master,
        drm_connector_cleanup(&tv->connector);
        drm_encoder_cleanup(&tv->encoder);
        clk_disable_unprepare(tv->clk);
+       reset_control_assert(tv->reset);
 }
 
 static const struct component_ops sun4i_tv_ops = {