staging: wfx: replace magic value by WFX_HIF_BUFFER_SIZE
authorJérôme Pouiller <jerome.pouiller@silabs.com>
Thu, 13 Jan 2022 08:55:02 +0000 (09:55 +0100)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Tue, 25 Jan 2022 15:19:41 +0000 (16:19 +0100)
Magic values are not recommended.

Signed-off-by: Jérôme Pouiller <jerome.pouiller@silabs.com>
Link: https://lore.kernel.org/r/20220113085524.1110708-10-Jerome.Pouiller@silabs.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/wfx/hwio.c

index a2a37ef..977b932 100644 (file)
@@ -15,6 +15,8 @@
 #include "bus.h"
 #include "traces.h"
 
+#define WFX_HIF_BUFFER_SIZE 0x2000
+
 static int read32(struct wfx_dev *wdev, int reg, u32 *val)
 {
        int ret;
@@ -103,7 +105,7 @@ static int indirect_read(struct wfx_dev *wdev, int reg, u32 addr,
        u32 cfg;
        u32 prefetch;
 
-       WARN_ON(len >= 0x2000);
+       WARN_ON(len >= WFX_HIF_BUFFER_SIZE);
        WARN_ON(reg != WFX_REG_AHB_DPORT && reg != WFX_REG_SRAM_DPORT);
 
        if (reg == WFX_REG_AHB_DPORT)
@@ -151,7 +153,7 @@ static int indirect_write(struct wfx_dev *wdev, int reg, u32 addr,
 {
        int ret;
 
-       WARN_ON(len >= 0x2000);
+       WARN_ON(len >= WFX_HIF_BUFFER_SIZE);
        WARN_ON(reg != WFX_REG_AHB_DPORT && reg != WFX_REG_SRAM_DPORT);
        ret = write32(wdev, WFX_REG_BASE_ADDR, addr);
        if (ret < 0)