scsi: target: sbp_target: Remove redundant assignment to pg_size
authorJiapeng Chong <jiapeng.chong@linux.alibaba.com>
Thu, 13 May 2021 10:49:37 +0000 (18:49 +0800)
committerMartin K. Petersen <martin.petersen@oracle.com>
Sat, 15 May 2021 03:09:24 +0000 (23:09 -0400)
Variable pg_size is set to '0x100 << pg_size', but this value is never read
and it is not used later on. Hence it is a redundant assignment and can be
removed.

Clean up the following clang-analyzer warning:

drivers/target/sbp/sbp_target.c:1264:3: warning: Value stored to
'pg_size' is never read [clang-analyzer-deadcode.DeadStores].

Link: https://lore.kernel.org/r/1620902977-57076-1-git-send-email-jiapeng.chong@linux.alibaba.com
Reported-by: Abaci Robot <abaci@linux.alibaba.com>
Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
drivers/target/sbp/sbp_target.c

index ce84f93..4d3ceee 100644 (file)
@@ -1261,7 +1261,6 @@ static int sbp_rw_data(struct sbp_target_request *req)
        pg_size = CMDBLK_ORB_PG_SIZE(be32_to_cpu(req->orb.misc));
        if (pg_size) {
                pr_err("sbp_run_transaction: page size ignored\n");
-               pg_size = 0x100 << pg_size;
        }
 
        spin_lock_bh(&sess->lock);