tools/power x86_energy_perf_policy: Fix file leak in get_pkg_num()
authorSamasth Norway Ananda <samasth.norway.ananda@oracle.com>
Wed, 14 Feb 2024 00:19:56 +0000 (16:19 -0800)
committerRafael J. Wysocki <rafael.j.wysocki@intel.com>
Thu, 22 Feb 2024 19:05:28 +0000 (20:05 +0100)
In function get_pkg_num() if fopen_or_die() succeeds it returns a file
pointer to be used. But fclose() is never called before returning from
the function.

Signed-off-by: Samasth Norway Ananda <samasth.norway.ananda@oracle.com>
Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
tools/power/x86/x86_energy_perf_policy/x86_energy_perf_policy.c

index 5fd9e59..ebda9c3 100644 (file)
@@ -1241,6 +1241,7 @@ unsigned int get_pkg_num(int cpu)
        retval = fscanf(fp, "%d\n", &pkg);
        if (retval != 1)
                errx(1, "%s: failed to parse", pathname);
+       fclose(fp);
        return pkg;
 }