fm10k: Fix fall-through warnings for Clang
authorGustavo A. R. Silva <gustavoars@kernel.org>
Fri, 5 Mar 2021 08:57:33 +0000 (02:57 -0600)
committerTony Nguyen <anthony.l.nguyen@intel.com>
Tue, 23 Mar 2021 18:34:02 +0000 (11:34 -0700)
In preparation to enable -Wimplicit-fallthrough for Clang, fix multiple
warnings by explicitly adding a couple of break statements instead of
just letting the code fall through to the next case.

Link: https://github.com/KSPP/linux/issues/115
Signed-off-by: Gustavo A. R. Silva <gustavoars@kernel.org>
Signed-off-by: Tony Nguyen <anthony.l.nguyen@intel.com>
drivers/net/ethernet/intel/fm10k/fm10k_mbx.c

index a2642b9..30ca9ee 100644 (file)
@@ -1039,6 +1039,7 @@ static s32 fm10k_mbx_create_reply(struct fm10k_hw *hw,
        case FM10K_STATE_CLOSED:
                /* generate new header based on data */
                fm10k_mbx_create_disconnect_hdr(mbx);
+               break;
        default:
                break;
        }
@@ -2017,6 +2018,7 @@ static s32 fm10k_sm_mbx_process_reset(struct fm10k_hw *hw,
        case FM10K_STATE_CONNECT:
                /* Update remote value to match local value */
                mbx->remote = mbx->local;
+               break;
        default:
                break;
        }