smb: server: use disable_work_sync in transport_rdma.c
authorStefan Metzmacher <metze@samba.org>
Wed, 13 Aug 2025 06:48:42 +0000 (08:48 +0200)
committerSteve French <stfrench@microsoft.com>
Mon, 22 Sep 2025 00:34:52 +0000 (19:34 -0500)
This makes it safer during the disconnect and avoids
requeueing.

It's ok to call disable_work[_sync]() more than once.

Cc: Namjae Jeon <linkinjeon@kernel.org>
Cc: Steve French <smfrench@gmail.com>
Cc: Tom Talpey <tom@talpey.com>
Cc: linux-cifs@vger.kernel.org
Cc: samba-technical@lists.samba.org
Fixes: 0626e6641f6b ("cifsd: add server handler for central processing and tranport layers")
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Acked-by: Namjae Jeon <linkinjeon@kernel.org>
Signed-off-by: Steve French <stfrench@microsoft.com>
fs/smb/server/transport_rdma.c

index 10a6b4e..74dfb64 100644 (file)
@@ -399,9 +399,9 @@ static void free_transport(struct smb_direct_transport *t)
        wait_event(t->wait_send_pending,
                   atomic_read(&t->send_pending) == 0);
 
-       cancel_work_sync(&t->disconnect_work);
-       cancel_work_sync(&t->post_recv_credits_work);
-       cancel_work_sync(&t->send_immediate_work);
+       disable_work_sync(&t->disconnect_work);
+       disable_work_sync(&t->post_recv_credits_work);
+       disable_work_sync(&t->send_immediate_work);
 
        if (t->qp) {
                ib_drain_qp(t->qp);