drm/rockchip: cdn-dp: Clean up a few logged messages
authorDragan Simic <dsimic@manjaro.org>
Wed, 3 Jul 2024 23:32:20 +0000 (01:32 +0200)
committerHeiko Stuebner <heiko@sntech.de>
Thu, 15 Aug 2024 10:29:19 +0000 (12:29 +0200)
Clean up a few logged messages, which were previously worded as rather
incomplete sentences separated by periods.  This was both a bit unreadable
and grammatically incorrect, so convert them into partial sentences separated
(or connected) by semicolons, together with some wording improvements.

Signed-off-by: Dragan Simic <dsimic@manjaro.org>
Reviewed-by: Andy Yan <andyshrk@163.com>
Signed-off-by: Heiko Stuebner <heiko@sntech.de>
Link: https://patchwork.freedesktop.org/patch/msgid/92db74a313547c087cc71059428698c4ec37a9ae.1720048818.git.dsimic@manjaro.org
drivers/gpu/drm/rockchip/cdn-dp-core.c

index 90913fa..b045389 100644 (file)
@@ -965,21 +965,21 @@ static void cdn_dp_pd_event_work(struct work_struct *work)
 
        /* Not connected, notify userspace to disable the block */
        if (!cdn_dp_connected_port(dp)) {
-               DRM_DEV_INFO(dp->dev, "Not connected. Disabling cdn\n");
+               DRM_DEV_INFO(dp->dev, "Not connected; disabling cdn\n");
                dp->connected = false;
 
        /* Connected but not enabled, enable the block */
        } else if (!dp->active) {
-               DRM_DEV_INFO(dp->dev, "Connected, not enabled. Enabling cdn\n");
+               DRM_DEV_INFO(dp->dev, "Connected, not enabled; enabling cdn\n");
                ret = cdn_dp_enable(dp);
                if (ret) {
-                       DRM_DEV_ERROR(dp->dev, "Enable dp failed %d\n", ret);
+                       DRM_DEV_ERROR(dp->dev, "Enabling dp failed: %d\n", ret);
                        dp->connected = false;
                }
 
        /* Enabled and connected to a dongle without a sink, notify userspace */
        } else if (!cdn_dp_check_sink_connection(dp)) {
-               DRM_DEV_INFO(dp->dev, "Connected without sink. Assert hpd\n");
+               DRM_DEV_INFO(dp->dev, "Connected without sink; assert hpd\n");
                dp->connected = false;
 
        /* Enabled and connected with a sink, re-train if requested */
@@ -988,11 +988,11 @@ static void cdn_dp_pd_event_work(struct work_struct *work)
                unsigned int lanes = dp->max_lanes;
                struct drm_display_mode *mode = &dp->mode;
 
-               DRM_DEV_INFO(dp->dev, "Connected with sink. Re-train link\n");
+               DRM_DEV_INFO(dp->dev, "Connected with sink; re-train link\n");
                ret = cdn_dp_train_link(dp);
                if (ret) {
                        dp->connected = false;
-                       DRM_DEV_ERROR(dp->dev, "Train link failed %d\n", ret);
+                       DRM_DEV_ERROR(dp->dev, "Training link failed: %d\n", ret);
                        goto out;
                }
 
@@ -1002,9 +1002,7 @@ static void cdn_dp_pd_event_work(struct work_struct *work)
                        ret = cdn_dp_config_video(dp);
                        if (ret) {
                                dp->connected = false;
-                               DRM_DEV_ERROR(dp->dev,
-                                             "Failed to config video %d\n",
-                                             ret);
+                               DRM_DEV_ERROR(dp->dev, "Failed to configure video: %d\n", ret);
                        }
                }
        }