staging: vchiq_core: return early in do_abort_bulks
authorStefan Wahren <stefan.wahren@i2se.com>
Sun, 25 Apr 2021 10:50:55 +0000 (12:50 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Mon, 10 May 2021 09:19:27 +0000 (11:19 +0200)
Avoid the multiline statement for notify_bulks by return early in
error case.

Reviewed-by: Nicolas Saenz Julienne <nsaenz@kernel.org>
Signed-off-by: Stefan Wahren <stefan.wahren@i2se.com>
Link: https://lore.kernel.org/r/1619347863-16080-4-git-send-email-stefan.wahren@i2se.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/vc04_services/interface/vchiq_arm/vchiq_core.c

index 8a1e6f5..f13d573 100644 (file)
@@ -2622,9 +2622,10 @@ do_abort_bulks(struct vchiq_service *service)
        mutex_unlock(&service->bulk_mutex);
 
        status = notify_bulks(service, &service->bulk_tx, 0/*!retry_poll*/);
-       if (status == VCHIQ_SUCCESS)
-               status = notify_bulks(service, &service->bulk_rx,
-                       0/*!retry_poll*/);
+       if (status != VCHIQ_SUCCESS)
+               return 0;
+
+       status = notify_bulks(service, &service->bulk_rx, 0/*!retry_poll*/);
        return (status == VCHIQ_SUCCESS);
 }