projects
/
linux-2.6-microblaze.git
/ commitdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
| commitdiff |
tree
raw
|
patch
| inline |
side by side
(parent:
238b638
)
mmc: mmci: Break IRQ status loop when all zero
author
Linus Walleij
<linus.walleij@linaro.org>
Sat, 16 Apr 2022 22:45:49 +0000
(
00:45
+0200)
committer
Ulf Hansson
<ulf.hansson@linaro.org>
Tue, 26 Apr 2022 12:05:22 +0000
(14:05 +0200)
We iterate an extra time through the IRQ status handling
loop despite nothing had fired. Enabling the debug prints:
mmci-pl18x
80005000
.mmc: op 01 arg
00000000
flags
000000e1
mmci-pl18x
80005000
.mmc: irq0 (data+cmd)
00000001
mmci-pl18x
80005000
.mmc: irq0 (data+cmd)
00000000
mmci-pl18x
80005000
.mmc: op 01 arg
40ff8080
flags
000000e1
mmci-pl18x
80005000
.mmc: irq0 (data+cmd)
00000001
mmci-pl18x
80005000
.mmc: irq0 (data+cmd)
00000000
It is pointless to loop through the function when status
is zero. Just break the loop if the status is zero.
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
Link:
https://lore.kernel.org/r/20220416224549.627623-1-linus.walleij@linaro.org
Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org>
drivers/mmc/host/mmci.c
patch
|
blob
|
history
diff --git
a/drivers/mmc/host/mmci.c
b/drivers/mmc/host/mmci.c
index
45b8608
..
f3cf315
100644
(file)
--- a/
drivers/mmc/host/mmci.c
+++ b/
drivers/mmc/host/mmci.c
@@
-1619,6
+1619,8
@@
static irqreturn_t mmci_irq(int irq, void *dev_id)
do {
status = readl(host->base + MMCISTATUS);
+ if (!status)
+ break;
if (host->singleirq) {
if (status & host->mask1_reg)