IB/isert: Do not excplicitly check == false for bool
authorZou Wei <zou_wei@huawei.com>
Tue, 3 Nov 2020 11:57:54 +0000 (19:57 +0800)
committerJason Gunthorpe <jgg@nvidia.com>
Thu, 12 Nov 2020 16:01:37 +0000 (12:01 -0400)
It is not the kernel style, warning reported by coccicheck:

./ib_isert.c:1104:12-24: WARNING: Comparison to bool

Link: https://lore.kernel.org/r/1604404674-32998-1-git-send-email-zou_wei@huawei.com
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Zou Wei <zou_wei@huawei.com>
Reviewed-by: Sagi Grimberg <sagi@grimberg.me>
Signed-off-by: Jason Gunthorpe <jgg@nvidia.com>
drivers/infiniband/ulp/isert/ib_isert.c

index bd47894..e47cd02 100644 (file)
@@ -1101,7 +1101,7 @@ isert_handle_scsi_cmd(struct isert_conn *isert_conn,
 sequence_cmd:
        rc = iscsit_sequence_cmd(conn, cmd, buf, hdr->cmdsn);
 
-       if (!rc && dump_payload == false && unsol_data)
+       if (!rc && !dump_payload && unsol_data)
                iscsit_set_unsolicited_dataout(cmd);
        else if (dump_payload && imm_data)
                target_put_sess_cmd(&cmd->se_cmd);