projects
/
linux-2.6-microblaze.git
/ commitdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
| commitdiff |
tree
raw
|
patch
| inline |
side by side
(parent:
eb72c46
)
panic: sys_info: deduplicate local variable 'table; assignments
author
Andy Shevchenko
<andriy.shevchenko@linux.intel.com>
Thu, 30 Oct 2025 11:44:21 +0000
(12:44 +0100)
committer
Andrew Morton
<akpm@linux-foundation.org>
Thu, 20 Nov 2025 22:03:40 +0000
(14:03 -0800)
The both handlers use the local 'table' variable and assign the same data
to it, deduplicate that.
Link:
https://lkml.kernel.org/r/20251030132007.3742368-6-andriy.shevchenko@linux.intel.com
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Reviewed-by: Feng Tang <feng.tang@linux.alibaba.com>
Reviewed-by: Petr Mladek <pmladek@suse.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
lib/sys_info.c
patch
|
blob
|
history
diff --git
a/lib/sys_info.c
b/lib/sys_info.c
index
eb5c122
..
94526de
100644
(file)
--- a/
lib/sys_info.c
+++ b/
lib/sys_info.c
@@
-63,12
+63,13
@@
int sysctl_sys_info_handler(const struct ctl_table *ro_table, int write,
if (!names)
return -ENOMEM;
+ table = *ro_table;
+ table.data = names;
+ table.maxlen = maxlen;
+
if (write) {
int ret;
- table = *ro_table;
- table.data = names;
- table.maxlen = maxlen;
ret = proc_dostring(&table, write, buffer, lenp, ppos);
if (ret)
return ret;
@@
-93,9
+94,6
@@
int sysctl_sys_info_handler(const struct ctl_table *ro_table, int write,
}
}
- table = *ro_table;
- table.data = names;
- table.maxlen = maxlen;
return proc_dostring(&table, write, buffer, lenp, ppos);
}
}