nvme-auth: remove redundant buffer deallocations
authorSagi Grimberg <sagi@grimberg.me>
Sun, 13 Nov 2022 11:24:09 +0000 (13:24 +0200)
committerChristoph Hellwig <hch@lst.de>
Wed, 16 Nov 2022 07:36:34 +0000 (08:36 +0100)
host_response, host_key, ctrl_key and sess_key are
freed in nvme_auth_reset_dhchap which is called from
nvme_auth_free_dhchap.

Reviewed-by: Hannes Reinecke <hare@suse.de>
Signed-off-by: Sagi Grimberg <sagi@grimberg.me>
Reviewed-by: Chaitanya Kulkarni <kch@nvidia.com>
Signed-off-by: Christoph Hellwig <hch@lst.de>
drivers/nvme/host/auth.c

index 4f2c8d0..0d0542e 100644 (file)
@@ -683,10 +683,6 @@ static void nvme_auth_free_dhchap(struct nvme_dhchap_queue_context *chap)
                crypto_free_shash(chap->shash_tfm);
        if (chap->dh_tfm)
                crypto_free_kpp(chap->dh_tfm);
-       kfree_sensitive(chap->ctrl_key);
-       kfree_sensitive(chap->host_key);
-       kfree_sensitive(chap->sess_key);
-       kfree_sensitive(chap->host_response);
        kfree(chap->buf);
        kfree(chap);
 }