sfc: use swap() to make code cleaner
authorYang Guang <yang.guang5@zte.com.cn>
Thu, 4 Nov 2021 06:53:50 +0000 (14:53 +0800)
committerDavid S. Miller <davem@davemloft.net>
Fri, 5 Nov 2021 10:14:38 +0000 (10:14 +0000)
Use the macro 'swap()' defined in 'include/linux/minmax.h' to avoid
opencoding it.

Reported-by: Zeal Robot <zealci@zte.com.cn>
Signed-off-by: Yang Guang <yang.guang5@zte.com.cn>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/sfc/falcon/efx.c

index c68837a..314c9c6 100644 (file)
@@ -817,9 +817,7 @@ ef4_realloc_channels(struct ef4_nic *efx, u32 rxq_entries, u32 txq_entries)
        efx->rxq_entries = rxq_entries;
        efx->txq_entries = txq_entries;
        for (i = 0; i < efx->n_channels; i++) {
-               channel = efx->channel[i];
-               efx->channel[i] = other_channel[i];
-               other_channel[i] = channel;
+               swap(efx->channel[i], other_channel[i]);
        }
 
        /* Restart buffer table allocation */
@@ -863,9 +861,7 @@ rollback:
        efx->rxq_entries = old_rxq_entries;
        efx->txq_entries = old_txq_entries;
        for (i = 0; i < efx->n_channels; i++) {
-               channel = efx->channel[i];
-               efx->channel[i] = other_channel[i];
-               other_channel[i] = channel;
+               swap(efx->channel[i], other_channel[i]);
        }
        goto out;
 }