net: bridge: rename br_fdb_insert to br_fdb_add_local
authorVladimir Oltean <vladimir.oltean@nxp.com>
Tue, 26 Oct 2021 14:27:39 +0000 (17:27 +0300)
committerDavid S. Miller <davem@davemloft.net>
Wed, 27 Oct 2021 13:54:02 +0000 (14:54 +0100)
br_fdb_insert() is a wrapper over fdb_insert() that also takes the
bridge hash_lock.

With fdb_insert() being renamed to fdb_add_local(), rename
br_fdb_insert() to br_fdb_add_local().

Signed-off-by: Vladimir Oltean <vladimir.oltean@nxp.com>
Reviewed-by: Ido Schimmel <idosch@nvidia.com>
Acked-by: Nikolay Aleksandrov <nikolay@nvidia.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
net/bridge/br_fdb.c
net/bridge/br_if.c
net/bridge/br_private.h
net/bridge/br_vlan.c

index 668f87d..09e7a1d 100644 (file)
@@ -679,8 +679,8 @@ int br_fdb_fillbuf(struct net_bridge *br, void *buf,
 }
 
 /* Add entry for local address of interface */
-int br_fdb_insert(struct net_bridge *br, struct net_bridge_port *source,
-                 const unsigned char *addr, u16 vid)
+int br_fdb_add_local(struct net_bridge *br, struct net_bridge_port *source,
+                    const unsigned char *addr, u16 vid)
 {
        int ret;
 
index c11bba3..c1183fe 100644 (file)
@@ -670,7 +670,7 @@ int br_add_if(struct net_bridge *br, struct net_device *dev,
        else
                netdev_set_rx_headroom(dev, br_hr);
 
-       if (br_fdb_insert(br, p, dev->dev_addr, 0))
+       if (br_fdb_add_local(br, p, dev->dev_addr, 0))
                netdev_err(dev, "failed insert local address bridge forwarding table\n");
 
        if (br->dev->addr_assign_type != NET_ADDR_SET) {
index 37ca764..705606f 100644 (file)
@@ -767,8 +767,8 @@ struct net_bridge_fdb_entry *br_fdb_find_rcu(struct net_bridge *br,
 int br_fdb_test_addr(struct net_device *dev, unsigned char *addr);
 int br_fdb_fillbuf(struct net_bridge *br, void *buf, unsigned long count,
                   unsigned long off);
-int br_fdb_insert(struct net_bridge *br, struct net_bridge_port *source,
-                 const unsigned char *addr, u16 vid);
+int br_fdb_add_local(struct net_bridge *br, struct net_bridge_port *source,
+                    const unsigned char *addr, u16 vid);
 void br_fdb_update(struct net_bridge *br, struct net_bridge_port *source,
                   const unsigned char *addr, u16 vid, unsigned long flags);
 
index 19f65ab..57bd6ee 100644 (file)
@@ -293,7 +293,7 @@ static int __vlan_add(struct net_bridge_vlan *v, u16 flags,
 
        /* Add the dev mac and count the vlan only if it's usable */
        if (br_vlan_should_use(v)) {
-               err = br_fdb_insert(br, p, dev->dev_addr, v->vid);
+               err = br_fdb_add_local(br, p, dev->dev_addr, v->vid);
                if (err) {
                        br_err(br, "failed insert local address into bridge forwarding table\n");
                        goto out_filt;
@@ -683,8 +683,7 @@ static int br_vlan_add_existing(struct net_bridge *br,
                        goto err_flags;
                }
                /* It was only kept for port vlans, now make it real */
-               err = br_fdb_insert(br, NULL, br->dev->dev_addr,
-                                   vlan->vid);
+               err = br_fdb_add_local(br, NULL, br->dev->dev_addr, vlan->vid);
                if (err) {
                        br_err(br, "failed to insert local address into bridge forwarding table\n");
                        goto err_fdb_insert;