leds: flash: leds-qcom-flash: Switch to device_for_each_child_node_scoped()

Switch to device_for_each_child_node_scoped() to simplify the code by
removing the need for calls to fwnode_handle_put() in the error paths.

This also prevents possible memory leaks if new error paths are added
without the required call to fwnode_handle_put().

Signed-off-by: Javier Carrasco <javier.carrasco.cruz@gmail.com>
Link: https://lore.kernel.org/r/20240927-leds_device_for_each_child_node_scoped-v1-3-95c0614b38c8@gmail.com
Signed-off-by: Lee Jones <lee@kernel.org>

diff --git a/drivers/leds/flash/leds-qcom-flash.c b/drivers/leds/flash/leds-qcom-flash.c
index 41ce034..ab848c5 100644 (file)
--- a/drivers/leds/flash/leds-qcom-flash.c
+++ b/drivers/leds/flash/leds-qcom-flash.c
@@ -812,7 +812,6 @@ static int qcom_flash_led_probe(struct platform_device *pdev)
 {
        struct qcom_flash_data *flash_data;
        struct qcom_flash_led *led;
-       struct fwnode_handle *child;
        struct device *dev = &pdev->dev;
        struct regmap *regmap;
        struct reg_field *regs;
@@ -896,7 +895,7 @@ static int qcom_flash_led_probe(struct platform_device *pdev)
        if (!flash_data->v4l2_flash)
                return -ENOMEM;
 
-       device_for_each_child_node(dev, child) {
+       device_for_each_child_node_scoped(dev, child) {
                led = devm_kzalloc(dev, sizeof(*led), GFP_KERNEL);
                if (!led) {
                        rc = -ENOMEM;
@@ -914,7 +913,6 @@ static int qcom_flash_led_probe(struct platform_device *pdev)
        return 0;
 
 release:
-       fwnode_handle_put(child);
        while (flash_data->v4l2_flash[flash_data->leds_count] && flash_data->leds_count)
                v4l2_flash_release(flash_data->v4l2_flash[flash_data->leds_count--]);
        return rc;