scsi: elx: libefc_sli: Fix ANDing with zero bit value
authorJames Smart <james.smart@broadcom.com>
Sat, 19 Jun 2021 15:56:41 +0000 (08:56 -0700)
committerMartin K. Petersen <martin.petersen@oracle.com>
Wed, 23 Jun 2021 01:07:30 +0000 (21:07 -0400)
Flags value is being set to a constant and ANDed with 0 which always
results in 0.

Remove the assignment line.

Link: https://lore.kernel.org/r/20210619155641.19942-1-jsmart2021@gmail.com
Fixes: 1628f5b4976f ("scsi: elx: libefc_sli: Populate and post different WQEs")
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Co-developed-by: Ram Vegesna <ram.vegesna@broadcom.com>
Signed-off-by: Ram Vegesna <ram.vegesna@broadcom.com>
Signed-off-by: James Smart <james.smart@broadcom.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
drivers/scsi/elx/libefc_sli/sli4.c

index fc24a50..6c6c04e 100644 (file)
@@ -2381,8 +2381,6 @@ sli_xmit_els_rsp64_wqe(struct sli4 *sli, void *buf, struct efc_dma *rsp,
 
        els->ox_id = cpu_to_le16(params->ox_id);
 
-       els->flags2 |= SLI4_ELS_IOD & SLI4_ELS_REQUEST64_DIR_WRITE;
-
        els->flags2 |= SLI4_ELS_QOSD;
 
        els->cmd_type_wqec = SLI4_ELS_REQUEST64_CMD_GEN;