net: bridge: declare br_vlan_tunnel_lookup argument tunnel_id as __be64
authorVladimir Oltean <vladimir.oltean@nxp.com>
Mon, 22 Mar 2021 10:38:19 +0000 (12:38 +0200)
committerDavid S. Miller <davem@davemloft.net>
Mon, 22 Mar 2021 20:11:59 +0000 (13:11 -0700)
The only caller of br_vlan_tunnel_lookup, br_handle_ingress_vlan_tunnel,
extracts the tunnel_id from struct ip_tunnel_info::struct ip_tunnel_key::
tun_id which is a __be64 value.

The exact endianness does not seem to matter, because the tunnel id is
just used as a lookup key for the VLAN group's tunnel hash table, and
the value is not interpreted directly per se. Moreover,
rhashtable_lookup_fast treats the key argument as a const void *.

Therefore, there is no functional change associated with this patch,
just one to silence "make W=1" builds.

Signed-off-by: Vladimir Oltean <vladimir.oltean@nxp.com>
Acked-by: Nikolay Aleksandrov <nikolay@nvidia.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
net/bridge/br_vlan_tunnel.c

index 169e005..0d3a8c0 100644 (file)
@@ -35,7 +35,7 @@ static const struct rhashtable_params br_vlan_tunnel_rht_params = {
 };
 
 static struct net_bridge_vlan *br_vlan_tunnel_lookup(struct rhashtable *tbl,
-                                                    u64 tunnel_id)
+                                                    __be64 tunnel_id)
 {
        return rhashtable_lookup_fast(tbl, &tunnel_id,
                                      br_vlan_tunnel_rht_params);