net: mana: Use the correct WQE count for ringing RQ doorbell
authorLong Li <longli@microsoft.com>
Mon, 17 Jul 2023 19:35:39 +0000 (12:35 -0700)
committerJakub Kicinski <kuba@kernel.org>
Wed, 19 Jul 2023 01:00:18 +0000 (18:00 -0700)
The hardware specification specifies that WQE_COUNT should set to 0 for
the Receive Queue. Although currently the hardware doesn't enforce the
check, in the future releases it may check on this value.

Reviewed-by: Haiyang Zhang <haiyangz@microsoft.com>
Reviewed-by: Dexuan Cui <decui@microsoft.com>
Signed-off-by: Long Li <longli@microsoft.com>
Link: https://lore.kernel.org/r/1689622539-5334-3-git-send-email-longli@linuxonhyperv.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
drivers/net/ethernet/microsoft/mana/gdma_main.c

index 8f3f78b..3765d33 100644 (file)
@@ -300,8 +300,11 @@ static void mana_gd_ring_doorbell(struct gdma_context *gc, u32 db_index,
 
 void mana_gd_wq_ring_doorbell(struct gdma_context *gc, struct gdma_queue *queue)
 {
+       /* Hardware Spec specifies that software client should set 0 for
+        * wqe_cnt for Receive Queues. This value is not used in Send Queues.
+        */
        mana_gd_ring_doorbell(gc, queue->gdma_dev->doorbell, queue->type,
-                             queue->id, queue->head * GDMA_WQE_BU_SIZE, 1);
+                             queue->id, queue->head * GDMA_WQE_BU_SIZE, 0);
 }
 
 void mana_gd_ring_cq(struct gdma_queue *cq, u8 arm_bit)