ACPI: property: Dig "rotation" property for devices with CSI2 _CRS
authorSakari Ailus <sakari.ailus@linux.intel.com>
Mon, 6 Nov 2023 16:28:40 +0000 (17:28 +0100)
committerRafael J. Wysocki <rafael.j.wysocki@intel.com>
Mon, 20 Nov 2023 15:50:48 +0000 (16:50 +0100)
Find the "rotation" property value for devices with _CRS CSI-2 resource
descriptors and use it to add the "rotation" property to the software
nodes representing the CSI-2 connection graph.  That value typically
comes from the _PLD (Physical Location of Device) object if it is
present for the given device.

This way, camera sensor drivers that know the "rotation" property do not
need to care about _PLD on systems using ACPI.

Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com>
[ rjw: Changelog edits, file rename ]
Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
Tested-by: Sakari Ailus <sakari.ailus@linux.intel.com>
drivers/acpi/mipi-disco-img.c
include/acpi/acpi_bus.h

index dcbaba9..b2c7a49 100644 (file)
@@ -595,6 +595,7 @@ static void init_crs_csi2_swnodes(struct crs_csi2 *csi2)
        struct acpi_buffer buffer = { .length = ACPI_ALLOCATE_BUFFER };
        struct acpi_device_software_nodes *swnodes = csi2->swnodes;
        acpi_handle handle = csi2->handle;
+       unsigned int prop_index = 0;
        struct fwnode_handle *adev_fwnode;
        struct acpi_device *adev;
        acpi_status status;
@@ -614,6 +615,22 @@ static void init_crs_csi2_swnodes(struct crs_csi2 *csi2)
 
        adev_fwnode = acpi_fwnode_handle(adev);
 
+       /*
+        * If the "rotation" property is not present, but _PLD is there,
+        * evaluate it to get the "rotation" value.
+        */
+       if (!fwnode_property_present(adev_fwnode, "rotation")) {
+               struct acpi_pld_info *pld;
+
+               status = acpi_get_physical_device_location(handle, &pld);
+               if (ACPI_SUCCESS(status)) {
+                       swnodes->dev_props[NEXT_PROPERTY(prop_index, DEV_ROTATION)] =
+                                       PROPERTY_ENTRY_U32("rotation",
+                                                          pld->rotation * 45U);
+                       kfree(pld);
+               }
+       }
+
        status = acpi_get_name(handle, ACPI_FULL_PATHNAME, &buffer);
        if (ACPI_FAILURE(status)) {
                acpi_handle_info(handle, "Unable to get the path name\n");
index c299fb9..1e5d2e2 100644 (file)
@@ -380,6 +380,7 @@ struct acpi_gpio_mapping;
 #define ACPI_DEVICE_SWNODE_PORT_NAME_LENGTH    8
 
 enum acpi_device_swnode_dev_props {
+       ACPI_DEVICE_SWNODE_DEV_ROTATION,
        ACPI_DEVICE_SWNODE_DEV_NUM_OF,
        ACPI_DEVICE_SWNODE_DEV_NUM_ENTRIES
 };