be2net: make two arrays static const, makes object smaller
authorColin Ian King <colin.king@canonical.com>
Fri, 6 Sep 2019 11:19:43 +0000 (12:19 +0100)
committerDavid S. Miller <davem@davemloft.net>
Sat, 7 Sep 2019 16:02:17 +0000 (18:02 +0200)
Don't populate the arrays on the stack but instead make them
static const. Makes the object code smaller by 281 bytes.

Before:
   text    data     bss     dec     hex filename
  87553    5672       0   93225   16c29 benet/be_cmds.o

After:
   text    data     bss     dec     hex filename
  87112    5832       0   92944   16b10 benet/be_cmds.o

(gcc version 9.2.1, amd64)

Signed-off-by: Colin Ian King <colin.king@canonical.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/emulex/benet/be_cmds.c

index 323976c..701c12c 100644 (file)
@@ -2756,7 +2756,7 @@ static int be_flash_BEx(struct be_adapter *adapter,
        bool crc_match;
        const u8 *p;
 
-       struct flash_comp gen3_flash_types[] = {
+       static const struct flash_comp gen3_flash_types[] = {
                { BE3_ISCSI_PRIMARY_IMAGE_START, OPTYPE_ISCSI_ACTIVE,
                        BE3_COMP_MAX_SIZE, IMAGE_FIRMWARE_ISCSI},
                { BE3_REDBOOT_START, OPTYPE_REDBOOT,
@@ -2779,7 +2779,7 @@ static int be_flash_BEx(struct be_adapter *adapter,
                        BE3_PHY_FW_COMP_MAX_SIZE, IMAGE_FIRMWARE_PHY}
        };
 
-       struct flash_comp gen2_flash_types[] = {
+       static const struct flash_comp gen2_flash_types[] = {
                { BE2_ISCSI_PRIMARY_IMAGE_START, OPTYPE_ISCSI_ACTIVE,
                        BE2_COMP_MAX_SIZE, IMAGE_FIRMWARE_ISCSI},
                { BE2_REDBOOT_START, OPTYPE_REDBOOT,