pinctrl: lynxpoint: Make use of for_each_requested_gpio()
authorAndy Shevchenko <andriy.shevchenko@linux.intel.com>
Wed, 10 Jun 2020 18:14:49 +0000 (21:14 +0300)
committerAndy Shevchenko <andriy.shevchenko@linux.intel.com>
Mon, 22 Jun 2020 08:01:59 +0000 (11:01 +0300)
Make use of for_each_requested_gpio() instead of home grown analogue.

Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Acked-by: Mika Westerberg <mika.westerberg@linux.intel.com>
drivers/pinctrl/intel/pinctrl-lynxpoint.c

index a45b8f2..2a3af99 100644 (file)
@@ -919,16 +919,17 @@ static int lp_gpio_runtime_resume(struct device *dev)
 static int lp_gpio_resume(struct device *dev)
 {
        struct intel_pinctrl *lg = dev_get_drvdata(dev);
+       struct gpio_chip *chip = &lg->chip;
+       const char *dummy;
        void __iomem *reg;
        int i;
 
        /* on some hardware suspend clears input sensing, re-enable it here */
-       for (i = 0; i < lg->chip.ngpio; i++) {
-               if (gpiochip_is_requested(&lg->chip, i) != NULL) {
-                       reg = lp_gpio_reg(&lg->chip, i, LP_CONFIG2);
-                       iowrite32(ioread32(reg) & ~GPINDIS_BIT, reg);
-               }
+       for_each_requested_gpio(chip, i, dummy) {
+               reg = lp_gpio_reg(chip, i, LP_CONFIG2);
+               iowrite32(ioread32(reg) & ~GPINDIS_BIT, reg);
        }
+
        return 0;
 }