pinctrl: th1520: Convert thp->mutex to guarded mutex
authorDrew Fustini <dfustini@tenstorrent.com>
Wed, 9 Oct 2024 01:16:47 +0000 (18:16 -0700)
committerLinus Walleij <linus.walleij@linaro.org>
Wed, 9 Oct 2024 12:42:07 +0000 (14:42 +0200)
Convert th1520_pinctrl_dt_node_to_map() to use guarded mutex for
thp->mutex.

Suggested-by: Linus Walleij <linus.walleij@linaro.org>
Signed-off-by: Drew Fustini <dfustini@tenstorrent.com>
Link: https://lore.kernel.org/20241008-th1520-pinctrl-fixes-v3-2-5b60db446a49@tenstorrent.com
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
drivers/pinctrl/pinctrl-th1520.c

index 265a75a..7ed3f82 100644 (file)
@@ -444,7 +444,7 @@ static int th1520_pinctrl_dt_node_to_map(struct pinctrl_dev *pctldev,
                return -ENOMEM;
 
        nmaps = 0;
-       mutex_lock(&thp->mutex);
+       guard(mutex)(&thp->mutex);
        for_each_available_child_of_node(np, child) {
                unsigned int rollback = nmaps;
                enum th1520_muxtype muxtype;
@@ -531,7 +531,6 @@ static int th1520_pinctrl_dt_node_to_map(struct pinctrl_dev *pctldev,
 
        *maps = map;
        *num_maps = nmaps;
-       mutex_unlock(&thp->mutex);
        return 0;
 
 free_configs:
@@ -539,7 +538,6 @@ free_configs:
 put_child:
        of_node_put(child);
        th1520_pinctrl_dt_free_map(pctldev, map, nmaps);
-       mutex_unlock(&thp->mutex);
        return ret;
 }