media: v4l: ioctl: Set bus_info in v4l_querycap()
authorSakari Ailus <sakari.ailus@linux.intel.com>
Sat, 22 Jan 2022 13:23:18 +0000 (13:23 +0000)
committerMauro Carvalho Chehab <mchehab@kernel.org>
Sun, 24 Apr 2022 07:07:08 +0000 (08:07 +0100)
The bus_info field is set by most drivers based on the type of the device
bus as well as the name of the device. Do this in v4l_querycap() so
drivers don't need to. This keeps compatibility with non-default and silly
bus_info.

Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com>
Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@kernel.org>
40 files changed:
drivers/media/common/saa7146/saa7146_video.c
drivers/media/pci/bt8xx/bttv-driver.c
drivers/media/pci/cx18/cx18-ioctl.c
drivers/media/pci/cx88/cx88-blackbird.c
drivers/media/pci/cx88/cx88-video.c
drivers/media/pci/dt3155/dt3155.c
drivers/media/pci/intel/ipu3/ipu3-cio2-main.c
drivers/media/pci/ivtv/ivtv-ioctl.c
drivers/media/pci/meye/meye.c
drivers/media/pci/saa7134/saa7134-video.c
drivers/media/pci/saa7164/saa7164-encoder.c
drivers/media/pci/saa7164/saa7164-vbi.c
drivers/media/pci/solo6x10/solo6x10-v4l2-enc.c
drivers/media/pci/solo6x10/solo6x10-v4l2.c
drivers/media/pci/sta2x11/sta2x11_vip.c
drivers/media/pci/tw5864/tw5864-video.c
drivers/media/pci/tw68/tw68-video.c
drivers/media/pci/tw686x/tw686x-video.c
drivers/media/platform/allegro-dvt/allegro-core.c
drivers/media/platform/marvell/cafe-driver.c
drivers/media/platform/mediatek/jpeg/mtk_jpeg_core.c
drivers/media/platform/nxp/imx-jpeg/mxc-jpeg.c
drivers/media/platform/qcom/camss/camss-video.c
drivers/media/platform/renesas/rcar-vin/rcar-v4l2.c
drivers/media/platform/renesas/rcar_jpu.c
drivers/media/platform/renesas/vsp1/vsp1_histo.c
drivers/media/platform/renesas/vsp1/vsp1_video.c
drivers/media/platform/samsung/exynos-gsc/gsc-m2m.c
drivers/media/platform/samsung/exynos4-is/common.c
drivers/media/platform/samsung/exynos4-is/fimc-lite.c
drivers/media/platform/samsung/s5p-jpeg/jpeg-core.c
drivers/media/platform/samsung/s5p-mfc/s5p_mfc_dec.c
drivers/media/platform/samsung/s5p-mfc/s5p_mfc_enc.c
drivers/media/platform/sunxi/sun4i-csi/sun4i_v4l2.c
drivers/media/platform/ti/cal/cal-video.c
drivers/media/platform/ti/davinci/vpbe_display.c
drivers/media/platform/ti/davinci/vpif_capture.c
drivers/media/platform/ti/davinci/vpif_display.c
drivers/media/radio/radio-maxiradio.c
drivers/media/v4l2-core/v4l2-ioctl.c

index 66215d9..2296765 100644 (file)
@@ -443,7 +443,6 @@ static int vidioc_querycap(struct file *file, void *fh, struct v4l2_capability *
 
        strscpy((char *)cap->driver, "saa7146 v4l2", sizeof(cap->driver));
        strscpy((char *)cap->card, dev->ext->name, sizeof(cap->card));
-       sprintf((char *)cap->bus_info, "PCI:%s", pci_name(dev->pci));
        cap->capabilities = V4L2_CAP_VIDEO_CAPTURE | V4L2_CAP_VIDEO_OVERLAY |
                            V4L2_CAP_READWRITE | V4L2_CAP_STREAMING |
                            V4L2_CAP_DEVICE_CAPS;
index 5ca3d0c..d40b537 100644 (file)
@@ -2435,8 +2435,6 @@ static int bttv_querycap(struct file *file, void  *priv,
 
        strscpy(cap->driver, "bttv", sizeof(cap->driver));
        strscpy(cap->card, btv->video_dev.name, sizeof(cap->card));
-       snprintf(cap->bus_info, sizeof(cap->bus_info),
-                "PCI:%s", pci_name(btv->c.pci));
        cap->capabilities = V4L2_CAP_VIDEO_CAPTURE | V4L2_CAP_READWRITE |
                            V4L2_CAP_STREAMING | V4L2_CAP_DEVICE_CAPS;
        if (no_overlay <= 0)
index ce3f014..c8ba784 100644 (file)
@@ -389,8 +389,6 @@ static int cx18_querycap(struct file *file, void *fh,
 
        strscpy(vcap->driver, CX18_DRIVER_NAME, sizeof(vcap->driver));
        strscpy(vcap->card, cx->card_name, sizeof(vcap->card));
-       snprintf(vcap->bus_info, sizeof(vcap->bus_info),
-                "PCI:%s", pci_name(cx->pci_dev));
        vcap->capabilities = cx->v4l2_cap | V4L2_CAP_DEVICE_CAPS;
        return 0;
 }
index d5da3bd..c1b41a9 100644 (file)
@@ -796,7 +796,6 @@ static int vidioc_querycap(struct file *file, void  *priv,
        struct cx88_core *core = dev->core;
 
        strscpy(cap->driver, "cx88_blackbird", sizeof(cap->driver));
-       sprintf(cap->bus_info, "PCI:%s", pci_name(dev->pci));
        return cx88_querycap(file, core, cap);
 }
 
index c17ad9f..d3729be 100644 (file)
@@ -808,7 +808,6 @@ static int vidioc_querycap(struct file *file, void  *priv,
        struct cx88_core *core = dev->core;
 
        strscpy(cap->driver, "cx8800", sizeof(cap->driver));
-       sprintf(cap->bus_info, "PCI:%s", pci_name(dev->pci));
        return cx88_querycap(file, core, cap);
 }
 
index 961f844..548156b 100644 (file)
@@ -292,11 +292,8 @@ static const struct v4l2_file_operations dt3155_fops = {
 static int dt3155_querycap(struct file *filp, void *p,
                           struct v4l2_capability *cap)
 {
-       struct dt3155_priv *pd = video_drvdata(filp);
-
        strscpy(cap->driver, DT3155_NAME, sizeof(cap->driver));
        strscpy(cap->card, DT3155_NAME " frame grabber", sizeof(cap->card));
-       sprintf(cap->bus_info, "PCI:%s", pci_name(pd->pdev));
        return 0;
 }
 
index b15fac7..0975a06 100644 (file)
@@ -1046,12 +1046,8 @@ static const struct vb2_ops cio2_vb2_ops = {
 static int cio2_v4l2_querycap(struct file *file, void *fh,
                              struct v4l2_capability *cap)
 {
-       struct cio2_device *cio2 = video_drvdata(file);
-
        strscpy(cap->driver, CIO2_NAME, sizeof(cap->driver));
        strscpy(cap->card, CIO2_DEVICE_NAME, sizeof(cap->card));
-       snprintf(cap->bus_info, sizeof(cap->bus_info),
-                "PCI:%s", pci_name(cio2->pci_dev));
 
        return 0;
 }
index fee460e..7947dcd 100644 (file)
@@ -732,7 +732,6 @@ static int ivtv_querycap(struct file *file, void *fh, struct v4l2_capability *vc
 
        strscpy(vcap->driver, IVTV_DRIVER_NAME, sizeof(vcap->driver));
        strscpy(vcap->card, itv->card_name, sizeof(vcap->card));
-       snprintf(vcap->bus_info, sizeof(vcap->bus_info), "PCI:%s", pci_name(itv->pdev));
        vcap->capabilities = itv->v4l2_cap | V4L2_CAP_DEVICE_CAPS;
        return 0;
 }
index 8944e4b..5d87efd 100644 (file)
@@ -1012,7 +1012,6 @@ static int vidioc_querycap(struct file *file, void *fh,
 {
        strscpy(cap->driver, "meye", sizeof(cap->driver));
        strscpy(cap->card, "meye", sizeof(cap->card));
-       sprintf(cap->bus_info, "PCI:%s", pci_name(meye.mchip_dev));
        return 0;
 }
 
index 48543ad..98c258a 100644 (file)
@@ -1475,7 +1475,6 @@ int saa7134_querycap(struct file *file, void *priv,
        strscpy(cap->driver, "saa7134", sizeof(cap->driver));
        strscpy(cap->card, saa7134_boards[dev->board].name,
                sizeof(cap->card));
-       sprintf(cap->bus_info, "PCI:%s", pci_name(dev->pci));
        cap->capabilities = V4L2_CAP_READWRITE | V4L2_CAP_STREAMING |
                            V4L2_CAP_RADIO | V4L2_CAP_VIDEO_CAPTURE |
                            V4L2_CAP_VBI_CAPTURE | V4L2_CAP_DEVICE_CAPS;
index 1d1d32e..c1b6a05 100644 (file)
@@ -490,7 +490,6 @@ static int vidioc_querycap(struct file *file, void  *priv,
        strscpy(cap->driver, dev->name, sizeof(cap->driver));
        strscpy(cap->card, saa7164_boards[dev->board].name,
                sizeof(cap->card));
-       sprintf(cap->bus_info, "PCI:%s", pci_name(dev->pci));
        cap->capabilities = V4L2_CAP_VIDEO_CAPTURE | V4L2_CAP_READWRITE |
                            V4L2_CAP_TUNER | V4L2_CAP_VBI_CAPTURE |
                            V4L2_CAP_DEVICE_CAPS;
index cb2e09f..a6738ba 100644 (file)
@@ -201,7 +201,6 @@ static int vidioc_querycap(struct file *file, void  *priv,
        strscpy(cap->driver, dev->name, sizeof(cap->driver));
        strscpy(cap->card, saa7164_boards[dev->board].name,
                sizeof(cap->card));
-       sprintf(cap->bus_info, "PCI:%s", pci_name(dev->pci));
        cap->capabilities = V4L2_CAP_VIDEO_CAPTURE | V4L2_CAP_READWRITE |
                            V4L2_CAP_TUNER | V4L2_CAP_VBI_CAPTURE |
                            V4L2_CAP_DEVICE_CAPS;
index 7766cad..80d20e2 100644 (file)
@@ -764,13 +764,10 @@ static int solo_enc_querycap(struct file *file, void  *priv,
                             struct v4l2_capability *cap)
 {
        struct solo_enc_dev *solo_enc = video_drvdata(file);
-       struct solo_dev *solo_dev = solo_enc->solo_dev;
 
        strscpy(cap->driver, SOLO6X10_NAME, sizeof(cap->driver));
        snprintf(cap->card, sizeof(cap->card), "Softlogic 6x10 Enc %d",
                 solo_enc->ch);
-       snprintf(cap->bus_info, sizeof(cap->bus_info), "PCI:%s",
-                pci_name(solo_dev->pdev));
        return 0;
 }
 
index 24ef0c4..e18cc41 100644 (file)
@@ -372,12 +372,8 @@ static const struct vb2_ops solo_video_qops = {
 static int solo_querycap(struct file *file, void  *priv,
                         struct v4l2_capability *cap)
 {
-       struct solo_dev *solo_dev = video_drvdata(file);
-
        strscpy(cap->driver, SOLO6X10_NAME, sizeof(cap->driver));
        strscpy(cap->card, "Softlogic 6x10", sizeof(cap->card));
-       snprintf(cap->bus_info, sizeof(cap->bus_info), "PCI:%s",
-                pci_name(solo_dev->pdev));
        return 0;
 }
 
index 524912f..8535e49 100644 (file)
@@ -401,12 +401,8 @@ static const struct v4l2_file_operations vip_fops = {
 static int vidioc_querycap(struct file *file, void *priv,
                           struct v4l2_capability *cap)
 {
-       struct sta2x11_vip *vip = video_drvdata(file);
-
        strscpy(cap->driver, KBUILD_MODNAME, sizeof(cap->driver));
        strscpy(cap->card, KBUILD_MODNAME, sizeof(cap->card));
-       snprintf(cap->bus_info, sizeof(cap->bus_info), "PCI:%s",
-                pci_name(vip->pdev));
        return 0;
 }
 
index 9131265..197ed89 100644 (file)
@@ -604,7 +604,6 @@ static int tw5864_querycap(struct file *file, void *priv,
        strscpy(cap->driver, "tw5864", sizeof(cap->driver));
        snprintf(cap->card, sizeof(cap->card), "TW5864 Encoder %d",
                 input->nr);
-       sprintf(cap->bus_info, "PCI:%s", pci_name(input->root->pci));
        return 0;
 }
 
index fe94944..0cbc5b0 100644 (file)
@@ -712,12 +712,9 @@ static int tw68_s_input(struct file *file, void *priv, unsigned int i)
 static int tw68_querycap(struct file *file, void  *priv,
                                        struct v4l2_capability *cap)
 {
-       struct tw68_dev *dev = video_drvdata(file);
-
        strscpy(cap->driver, "tw68", sizeof(cap->driver));
        strscpy(cap->card, "Techwell Capture Card",
                sizeof(cap->card));
-       sprintf(cap->bus_info, "PCI:%s", pci_name(dev->pci));
        return 0;
 }
 
index b227e9e..6344a47 100644 (file)
@@ -762,8 +762,6 @@ static int tw686x_querycap(struct file *file, void *priv,
 
        strscpy(cap->driver, "tw686x", sizeof(cap->driver));
        strscpy(cap->card, dev->name, sizeof(cap->card));
-       snprintf(cap->bus_info, sizeof(cap->bus_info),
-                "PCI:%s", pci_name(dev->pci_dev));
        return 0;
 }
 
index 4a3d06c..2423714 100644 (file)
@@ -3249,13 +3249,8 @@ static int allegro_release(struct file *file)
 static int allegro_querycap(struct file *file, void *fh,
                            struct v4l2_capability *cap)
 {
-       struct video_device *vdev = video_devdata(file);
-       struct allegro_dev *dev = video_get_drvdata(vdev);
-
        strscpy(cap->driver, KBUILD_MODNAME, sizeof(cap->driver));
        strscpy(cap->card, "Allegro DVT Video Encoder", sizeof(cap->card));
-       snprintf(cap->bus_info, sizeof(cap->bus_info), "platform:%s",
-                dev_name(&dev->plat_dev->dev));
 
        return 0;
 }
index 03dcf8b..ae97ce4 100644 (file)
@@ -497,7 +497,6 @@ static int cafe_pci_probe(struct pci_dev *pdev,
        mcam->plat_power_up = cafe_ctlr_power_up;
        mcam->plat_power_down = cafe_ctlr_power_down;
        mcam->dev = &pdev->dev;
-       snprintf(mcam->bus_info, sizeof(mcam->bus_info), "PCI:%s", pci_name(pdev));
        /*
         * Vmalloc mode for buffers is traditional with this driver.
         * We *might* be able to run DMA_contig, especially on a system
index ab5485d..bc5b0a0 100644 (file)
@@ -137,8 +137,6 @@ static int mtk_jpeg_querycap(struct file *file, void *priv,
 
        strscpy(cap->driver, jpeg->variant->dev_name, sizeof(cap->driver));
        strscpy(cap->card, jpeg->variant->dev_name, sizeof(cap->card));
-       snprintf(cap->bus_info, sizeof(cap->bus_info), "platform:%s",
-                dev_name(jpeg->dev));
 
        return 0;
 }
index d1ec1f4..c9ca757 100644 (file)
@@ -1569,12 +1569,8 @@ free:
 static int mxc_jpeg_querycap(struct file *file, void *priv,
                             struct v4l2_capability *cap)
 {
-       struct mxc_jpeg_dev *mxc_jpeg = video_drvdata(file);
-
        strscpy(cap->driver, MXC_JPEG_NAME " codec", sizeof(cap->driver));
        strscpy(cap->card, MXC_JPEG_NAME " codec", sizeof(cap->card));
-       snprintf(cap->bus_info, sizeof(cap->bus_info), "platform:%s",
-                dev_name(mxc_jpeg->dev));
        cap->device_caps = V4L2_CAP_STREAMING | V4L2_CAP_VIDEO_M2M_MPLANE;
        cap->capabilities = cap->device_caps | V4L2_CAP_DEVICE_CAPS;
 
index 5dc1ddb..307bb1d 100644 (file)
@@ -576,12 +576,8 @@ static const struct vb2_ops msm_video_vb2_q_ops = {
 static int video_querycap(struct file *file, void *fh,
                          struct v4l2_capability *cap)
 {
-       struct camss_video *video = video_drvdata(file);
-
        strscpy(cap->driver, "qcom-camss", sizeof(cap->driver));
        strscpy(cap->card, "Qualcomm Camera Subsystem", sizeof(cap->card));
-       snprintf(cap->bus_info, sizeof(cap->bus_info), "platform:%s",
-                dev_name(video->camss->dev));
 
        return 0;
 }
index 2e60b9f..287fbf2 100644 (file)
@@ -307,12 +307,8 @@ done:
 static int rvin_querycap(struct file *file, void *priv,
                         struct v4l2_capability *cap)
 {
-       struct rvin_dev *vin = video_drvdata(file);
-
        strscpy(cap->driver, KBUILD_MODNAME, sizeof(cap->driver));
        strscpy(cap->card, "R_Car_VIN", sizeof(cap->card));
-       snprintf(cap->bus_info, sizeof(cap->bus_info), "platform:%s",
-                dev_name(vin->dev));
        return 0;
 }
 
index 293beba..2f4377c 100644 (file)
@@ -670,8 +670,6 @@ static int jpu_querycap(struct file *file, void *priv,
                strscpy(cap->card, DRV_NAME " decoder", sizeof(cap->card));
 
        strscpy(cap->driver, DRV_NAME, sizeof(cap->driver));
-       snprintf(cap->bus_info, sizeof(cap->bus_info), "platform:%s",
-                dev_name(ctx->jpu->dev));
        memset(cap->reserved, 0, sizeof(cap->reserved));
 
        return 0;
index 5e5013d..f22449d 100644 (file)
@@ -434,8 +434,6 @@ static int histo_v4l2_querycap(struct file *file, void *fh,
 
        strscpy(cap->driver, "vsp1", sizeof(cap->driver));
        strscpy(cap->card, histo->video.name, sizeof(cap->card));
-       snprintf(cap->bus_info, sizeof(cap->bus_info), "platform:%s",
-                dev_name(histo->entity.vsp1->dev));
 
        return 0;
 }
index 044eb57..497f352 100644 (file)
@@ -959,8 +959,6 @@ vsp1_video_querycap(struct file *file, void *fh, struct v4l2_capability *cap)
 
        strscpy(cap->driver, "vsp1", sizeof(cap->driver));
        strscpy(cap->card, video->video.name, sizeof(cap->card));
-       snprintf(cap->bus_info, sizeof(cap->bus_info), "platform:%s",
-                dev_name(video->vsp1->dev));
 
        return 0;
 }
index f1cf847..b7854ce 100644 (file)
@@ -285,13 +285,8 @@ static const struct vb2_ops gsc_m2m_qops = {
 static int gsc_m2m_querycap(struct file *file, void *fh,
                           struct v4l2_capability *cap)
 {
-       struct gsc_ctx *ctx = fh_to_ctx(fh);
-       struct gsc_dev *gsc = ctx->gsc_dev;
-
        strscpy(cap->driver, GSC_MODULE_NAME, sizeof(cap->driver));
        strscpy(cap->card, GSC_MODULE_NAME " gscaler", sizeof(cap->card));
-       snprintf(cap->bus_info, sizeof(cap->bus_info), "platform:%s",
-                dev_name(&gsc->pdev->dev));
        return 0;
 }
 
index 023f624..26ee238 100644 (file)
@@ -41,8 +41,6 @@ void __fimc_vidioc_querycap(struct device *dev, struct v4l2_capability *cap)
 {
        strscpy(cap->driver, dev->driver->name, sizeof(cap->driver));
        strscpy(cap->card, dev->driver->name, sizeof(cap->card));
-       snprintf(cap->bus_info, sizeof(cap->bus_info),
-                               "platform:%s", dev_name(dev));
 }
 EXPORT_SYMBOL(__fimc_vidioc_querycap);
 
index 2e8f476..1a396b7 100644 (file)
@@ -646,12 +646,8 @@ static void fimc_lite_try_compose(struct fimc_lite *fimc, struct v4l2_rect *r)
 static int fimc_lite_querycap(struct file *file, void *priv,
                                        struct v4l2_capability *cap)
 {
-       struct fimc_lite *fimc = video_drvdata(file);
-
        strscpy(cap->driver, FIMC_LITE_DRV_NAME, sizeof(cap->driver));
        strscpy(cap->card, FIMC_LITE_DRV_NAME, sizeof(cap->card));
-       snprintf(cap->bus_info, sizeof(cap->bus_info), "platform:%s",
-                                       dev_name(&fimc->pdev->dev));
        return 0;
 }
 
index 5479bc8..4562871 100644 (file)
@@ -1257,8 +1257,6 @@ static int s5p_jpeg_querycap(struct file *file, void *priv,
                strscpy(cap->card, S5P_JPEG_M2M_NAME " decoder",
                        sizeof(cap->card));
        }
-       snprintf(cap->bus_info, sizeof(cap->bus_info), "platform:%s",
-                dev_name(ctx->jpeg->dev));
        return 0;
 }
 
index 4b89df8..268ffe4 100644 (file)
@@ -288,8 +288,6 @@ static int vidioc_querycap(struct file *file, void *priv,
 
        strscpy(cap->driver, S5P_MFC_NAME, sizeof(cap->driver));
        strscpy(cap->card, dev->vfd_dec->name, sizeof(cap->card));
-       snprintf(cap->bus_info, sizeof(cap->bus_info), "platform:%s",
-                dev_name(&dev->plat_dev->dev));
        return 0;
 }
 
index a8877d8..b65e506 100644 (file)
@@ -1309,8 +1309,6 @@ static int vidioc_querycap(struct file *file, void *priv,
 
        strscpy(cap->driver, S5P_MFC_NAME, sizeof(cap->driver));
        strscpy(cap->card, dev->vfd_enc->name, sizeof(cap->card));
-       snprintf(cap->bus_info, sizeof(cap->bus_info), "platform:%s",
-                dev_name(&dev->plat_dev->dev));
        return 0;
 }
 
index 3872027..4870213 100644 (file)
@@ -53,12 +53,8 @@ const struct sun4i_csi_format *sun4i_csi_find_format(const u32 *fourcc,
 static int sun4i_csi_querycap(struct file *file, void *priv,
                              struct v4l2_capability *cap)
 {
-       struct sun4i_csi *csi = video_drvdata(file);
-
        strscpy(cap->driver, KBUILD_MODNAME, sizeof(cap->driver));
        strscpy(cap->card, "sun4i-csi", sizeof(cap->card));
-       snprintf(cap->bus_info, sizeof(cap->bus_info), "platform:%s",
-                dev_name(csi->dev));
 
        return 0;
 }
index 3e936a2..07ae1a3 100644 (file)
@@ -47,13 +47,9 @@ static char *fourcc_to_str(u32 fmt)
 static int cal_querycap(struct file *file, void *priv,
                        struct v4l2_capability *cap)
 {
-       struct cal_ctx *ctx = video_drvdata(file);
-
        strscpy(cap->driver, CAL_MODULE_NAME, sizeof(cap->driver));
        strscpy(cap->card, CAL_MODULE_NAME, sizeof(cap->card));
 
-       snprintf(cap->bus_info, sizeof(cap->bus_info),
-                "platform:%s", dev_name(ctx->cal->dev));
        return 0;
 }
 
index bf3c3e7..9ea7081 100644 (file)
@@ -630,8 +630,6 @@ static int vpbe_display_querycap(struct file *file, void  *priv,
 
        snprintf(cap->driver, sizeof(cap->driver), "%s",
                dev_name(vpbe_dev->pdev));
-       snprintf(cap->bus_info, sizeof(cap->bus_info), "platform:%s",
-                dev_name(vpbe_dev->pdev));
        strscpy(cap->card, vpbe_dev->cfg->module_name, sizeof(cap->card));
 
        return 0;
index bf76c5c..b91eec8 100644 (file)
@@ -1067,8 +1067,6 @@ static int vpif_querycap(struct file *file, void  *priv,
        struct vpif_capture_config *config = vpif_dev->platform_data;
 
        strscpy(cap->driver, VPIF_DRIVER_NAME, sizeof(cap->driver));
-       snprintf(cap->bus_info, sizeof(cap->bus_info), "platform:%s",
-                dev_name(vpif_dev));
        strscpy(cap->card, config->card_name, sizeof(cap->card));
 
        return 0;
index fca148b..4b7c896 100644 (file)
@@ -585,8 +585,6 @@ static int vpif_querycap(struct file *file, void  *priv,
        struct vpif_display_config *config = vpif_dev->platform_data;
 
        strscpy(cap->driver, VPIF_DRIVER_NAME, sizeof(cap->driver));
-       snprintf(cap->bus_info, sizeof(cap->bus_info), "platform:%s",
-                dev_name(vpif_dev));
        strscpy(cap->card, config->card_name, sizeof(cap->card));
 
        return 0;
index de107e2..1a5dbae 100644 (file)
@@ -144,8 +144,6 @@ static int maxiradio_probe(struct pci_dev *pdev,
        dev->tea.v4l2_dev = v4l2_dev;
        dev->tea.radio_nr = radio_nr;
        strscpy(dev->tea.card, "Maxi Radio FM2000", sizeof(dev->tea.card));
-       snprintf(dev->tea.bus_info, sizeof(dev->tea.bus_info),
-                       "PCI:%s", pci_name(pdev));
 
        retval = -ENODEV;
 
index 96e307f..db5947f 100644 (file)
@@ -18,6 +18,7 @@
 
 #include <linux/videodev2.h>
 
+#include <media/media-device.h> /* for media_set_bus_info() */
 #include <media/v4l2-common.h>
 #include <media/v4l2-ioctl.h>
 #include <media/v4l2-ctrls.h>
@@ -1052,6 +1053,9 @@ static int v4l_querycap(const struct v4l2_ioctl_ops *ops,
        cap->device_caps = vfd->device_caps;
        cap->capabilities = vfd->device_caps | V4L2_CAP_DEVICE_CAPS;
 
+       media_set_bus_info(cap->bus_info, sizeof(cap->bus_info),
+                          vfd->dev_parent);
+
        ret = ops->vidioc_querycap(file, fh, cap);
 
        /*