scsi: megaraid: Fix up debug message in megaraid_abort_and_reset()
authorHannes Reinecke <hare@suse.de>
Mon, 23 Oct 2023 07:30:21 +0000 (09:30 +0200)
committerMartin K. Petersen <martin.petersen@oracle.com>
Wed, 25 Oct 2023 02:40:39 +0000 (22:40 -0400)
Found by Smatch.

Fixes: 5bcd3bfbda02 ("scsi: megaraid: Pass in NULL scb for host reset")
Reported-by: Dan Carpenter <dan.carpenter@linaro.org>
Signed-off-by: Hannes Reinecke <hare@suse.de>
Link: https://lore.kernel.org/r/20231023073021.21954-1-hare@suse.de
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
drivers/scsi/megaraid.c

index 329c3da..66a30a3 100644 (file)
@@ -1925,10 +1925,13 @@ megaraid_abort_and_reset(adapter_t *adapter, struct scsi_cmnd *cmd, int aor)
        struct list_head        *pos, *next;
        scb_t                   *scb;
 
-       dev_warn(&adapter->dev->dev, "%s cmd=%x <c=%d t=%d l=%d>\n",
-            (aor == SCB_ABORT)? "ABORTING":"RESET",
-            cmd->cmnd[0], cmd->device->channel,
-            cmd->device->id, (u32)cmd->device->lun);
+       if (aor == SCB_ABORT)
+               dev_warn(&adapter->dev->dev,
+                        "ABORTING cmd=%x <c=%d t=%d l=%d>\n",
+                        cmd->cmnd[0], cmd->device->channel,
+                        cmd->device->id, (u32)cmd->device->lun);
+       else
+               dev_warn(&adapter->dev->dev, "RESETTING\n");
 
        if(list_empty(&adapter->pending_list))
                return FAILED;