ipv6: remove redundant null pointer check before kfree_skb
authorzhong jiang <zhongjiang@huawei.com>
Thu, 20 Sep 2018 09:37:46 +0000 (17:37 +0800)
committerDavid S. Miller <davem@davemloft.net>
Fri, 21 Sep 2018 16:04:37 +0000 (09:04 -0700)
kfree_skb has taken the null pointer into account. hence it is safe
to remove the redundant null pointer check before kfree_skb.

Signed-off-by: zhong jiang <zhongjiang@huawei.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
net/ipv6/af_inet6.c

index 77ef847..e9c8cfd 100644 (file)
@@ -468,12 +468,10 @@ void inet6_destroy_sock(struct sock *sk)
        /* Release rx options */
 
        skb = xchg(&np->pktoptions, NULL);
-       if (skb)
-               kfree_skb(skb);
+       kfree_skb(skb);
 
        skb = xchg(&np->rxpmtu, NULL);
-       if (skb)
-               kfree_skb(skb);
+       kfree_skb(skb);
 
        /* Free flowlabels */
        fl6_free_socklist(sk);