drm/msm/dpu: make "vblank timeout" more useful
authorDmitry Baryshkov <dmitry.baryshkov@linaro.org>
Mon, 26 Feb 2024 02:27:59 +0000 (04:27 +0200)
committerDmitry Baryshkov <dmitry.baryshkov@linaro.org>
Mon, 4 Mar 2024 09:41:09 +0000 (11:41 +0200)
We have several reports of vblank timeout messages. However after some
debugging it was found that there might be different causes to that.
To allow us to identify the DPU block that gets stuck, include the
actual CTL_FLUSH value into the timeout message.

Reviewed-by: Abhinav Kumar <quic_abhinavk@quicinc.com>
Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
Patchwork: https://patchwork.freedesktop.org/patch/579849/
Link: https://lore.kernel.org/r/20240226-fd-dpu-debug-timeout-v4-1-51eec83dde23@linaro.org
drivers/gpu/drm/msm/disp/dpu1/dpu_encoder_phys_vid.c

index 2ff4429..d9e7dbf 100644 (file)
@@ -502,7 +502,7 @@ static int dpu_encoder_phys_vid_wait_for_commit_done(
                (hw_ctl->ops.get_flush_register(hw_ctl) == 0),
                msecs_to_jiffies(50));
        if (ret <= 0) {
-               DPU_ERROR("vblank timeout\n");
+               DPU_ERROR("vblank timeout: %x\n", hw_ctl->ops.get_flush_register(hw_ctl));
                return -ETIMEDOUT;
        }