ALSA: ali5451: remove redundant variable capture_flag
authorColin Ian King <colin.king@canonical.com>
Sat, 8 Feb 2020 22:34:43 +0000 (22:34 +0000)
committerTakashi Iwai <tiwai@suse.de>
Mon, 10 Feb 2020 07:29:54 +0000 (08:29 +0100)
Variable capture_flag is only ever assigned values, it is never read
and hence it is redundant. Remove it.

Addresses-Coverity ("Unused value")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
Link: https://lore.kernel.org/r/20200208223443.38047-1-colin.king@canonical.com
Signed-off-by: Takashi Iwai <tiwai@suse.de>
sound/pci/ali5451/ali5451.c

index 4f524a9..4462375 100644 (file)
@@ -1070,7 +1070,7 @@ static int snd_ali_trigger(struct snd_pcm_substream *substream,
 {
        struct snd_ali *codec = snd_pcm_substream_chip(substream);
        struct snd_pcm_substream *s;
-       unsigned int what, whati, capture_flag;
+       unsigned int what, whati;
        struct snd_ali_voice *pvoice, *evoice;
        unsigned int val;
        int do_start;
@@ -1088,7 +1088,7 @@ static int snd_ali_trigger(struct snd_pcm_substream *substream,
                return -EINVAL;
        }
 
-       what = whati = capture_flag = 0;
+       what = whati = 0;
        snd_pcm_group_for_each_entry(s, substream) {
                if ((struct snd_ali *) snd_pcm_substream_chip(s) == codec) {
                        pvoice = s->runtime->private_data;
@@ -1110,8 +1110,6 @@ static int snd_ali_trigger(struct snd_pcm_substream *substream,
                                        evoice->running = 0;
                        }
                        snd_pcm_trigger_done(s, substream);
-                       if (pvoice->mode)
-                               capture_flag = 1;
                }
        }
        spin_lock(&codec->reg_lock);