cpufreq: qcom-hw: Use devm_platform_ioremap_resource() to simplify code
authorManivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
Tue, 15 Sep 2020 07:24:21 +0000 (12:54 +0530)
committerViresh Kumar <viresh.kumar@linaro.org>
Wed, 16 Sep 2020 08:42:18 +0000 (14:12 +0530)
devm_platform_ioremap_resource() is the combination of
platform_get_resource() and devm_ioremap_resource(). Hence, use it to
simplify the code a bit.

Signed-off-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
Reviewed-by: Amit Kucheria <amitk@kernel.org>
Reviewed-by: Bjorn Andersson <bjorn.andersson@linaro.org>
Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org>
drivers/cpufreq/qcom-cpufreq-hw.c

index ccea34f..8a30378 100644 (file)
@@ -244,7 +244,6 @@ static int qcom_cpufreq_hw_cpu_init(struct cpufreq_policy *policy)
        struct of_phandle_args args;
        struct device_node *cpu_np;
        struct device *cpu_dev;
-       struct resource *res;
        void __iomem *base;
        int ret, index;
 
@@ -267,13 +266,9 @@ static int qcom_cpufreq_hw_cpu_init(struct cpufreq_policy *policy)
 
        index = args.args[0];
 
-       res = platform_get_resource(pdev, IORESOURCE_MEM, index);
-       if (!res)
-               return -ENODEV;
-
-       base = devm_ioremap(dev, res->start, resource_size(res));
-       if (!base)
-               return -ENOMEM;
+       base = devm_platform_ioremap_resource(pdev, index);
+       if (IS_ERR(base))
+               return PTR_ERR(base);
 
        /* HW should be in enabled state to proceed */
        if (!(readl_relaxed(base + REG_ENABLE) & 0x1)) {