Input: Fix fall-through warning for Clang
authorGustavo A. R. Silva <gustavoars@kernel.org>
Tue, 6 Jul 2021 21:05:26 +0000 (16:05 -0500)
committerGustavo A. R. Silva <gustavoars@kernel.org>
Tue, 6 Jul 2021 21:26:17 +0000 (16:26 -0500)
In preparation to enable -Wimplicit-fallthrough for Clang, fix a
warning by explicitly adding a fallthrough; statement.

Notice that this seems to be a Duff device for performance[1]. So,
although the code looks a bit _funny_, I didn't want to refactor
or modify it beyond merely adding a fallthrough marking, which
might be the least disruptive way to fix this issue.

[1] https://www.drdobbs.com/a-reusable-duff-device/184406208

Link: https://github.com/KSPP/linux/issues/115
Signed-off-by: Gustavo A. R. Silva <gustavoars@kernel.org>
drivers/input/joystick/sidewinder.c

index fac91ea..8e9672d 100644 (file)
@@ -660,6 +660,7 @@ static int sw_connect(struct gameport *gameport, struct gameport_driver *drv)
                                        fallthrough;
                                case 45:                                /* Ambiguous packet length */
                                        if (j <= 40) {                  /* ID length less or eq 40 -> FSP */
+                                       fallthrough;
                                case 43:
                                                sw->type = SW_ID_FSP;
                                                break;