net: phylink: move MLO_AN_PHY resolve handling to if() statement
authorRussell King (Oracle) <rmk+kernel@armlinux.org.uk>
Fri, 8 Nov 2024 16:01:55 +0000 (16:01 +0000)
committerJakub Kicinski <kuba@kernel.org>
Tue, 12 Nov 2024 03:05:14 +0000 (19:05 -0800)
The switch() statement doesn't sit very well with the preceeding if()
statements, and results in excessive indentation that spoils code
readability. Continue cleaning this up by converting the MLO_AN_PHY
case to use an if() statmeent.

Signed-off-by: Russell King (Oracle) <rmk+kernel@armlinux.org.uk>
Link: https://patch.msgid.link/E1t9RQp-002Fet-5W@rmk-PC.armlinux.org.uk
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
drivers/net/phy/phylink.c

index bb20ae5..3af6368 100644 (file)
@@ -1466,13 +1466,11 @@ static void phylink_resolve(struct work_struct *w)
        } else if (pl->cur_link_an_mode == MLO_AN_FIXED) {
                phylink_get_fixed_state(pl, &link_state);
                mac_config = link_state.link;
+       } else if (pl->cur_link_an_mode == MLO_AN_PHY) {
+               link_state = pl->phy_state;
+               mac_config = link_state.link;
        } else {
                switch (pl->cur_link_an_mode) {
-               case MLO_AN_PHY:
-                       link_state = pl->phy_state;
-                       mac_config = link_state.link;
-                       break;
-
                case MLO_AN_INBAND:
                        phylink_mac_pcs_get_state(pl, &link_state);